[PATCH v5 25/25] media: hantro: use pm_runtime_resume_and_get()
Mauro Carvalho Chehab
mchehab+huawei at kernel.org
Thu May 6 08:26:03 PDT 2021
Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter")
added pm_runtime_resume_and_get() in order to automatically handle
dev->power.usage_count decrement on errors.
While there's nothing wrong with the current usage on this driver,
as we're getting rid of the pm_runtime_get_sync() call all over
the media subsystem, let's remove the last occurrence on this
driver.
Reviewed-by: Ezequiel Garcia <ezequiel at collabora.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei at kernel.org>
---
drivers/staging/media/hantro/hantro_drv.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/media/hantro/hantro_drv.c b/drivers/staging/media/hantro/hantro_drv.c
index eea2009fa17b..74d6545395f9 100644
--- a/drivers/staging/media/hantro/hantro_drv.c
+++ b/drivers/staging/media/hantro/hantro_drv.c
@@ -160,9 +160,8 @@ static void device_run(void *priv)
src = hantro_get_src_buf(ctx);
dst = hantro_get_dst_buf(ctx);
- ret = pm_runtime_get_sync(ctx->dev->dev);
- if (ret < 0) {
- pm_runtime_put_noidle(ctx->dev->dev);
+ ret = pm_runtime_resume_and_get(ctx->dev->dev);
+ if (ret < 0)
goto err_cancel_job;
}
--
2.30.2
More information about the Linux-rockchip
mailing list