[PATCH v2 06/22] drm/malidp: Don't set struct drm_device.irq_enabled
Liviu Dudau
liviu.dudau at arm.com
Tue Jun 22 08:26:32 PDT 2021
On Tue, Jun 22, 2021 at 04:09:46PM +0200, Thomas Zimmermann wrote:
> The field drm_device.irq_enabled is only used by legacy drivers
> with userspace modesetting. Don't set it in malidp.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de>
Acked-by: Liviu Dudau <liviu.dudau at arm.com>
Best regards,
Liviu
> ---
> drivers/gpu/drm/arm/malidp_drv.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c
> index de59f3302516..78d15b04b105 100644
> --- a/drivers/gpu/drm/arm/malidp_drv.c
> +++ b/drivers/gpu/drm/arm/malidp_drv.c
> @@ -847,8 +847,6 @@ static int malidp_bind(struct device *dev)
> if (ret < 0)
> goto irq_init_fail;
>
> - drm->irq_enabled = true;
> -
> ret = drm_vblank_init(drm, drm->mode_config.num_crtc);
> if (ret < 0) {
> DRM_ERROR("failed to initialise vblank\n");
> @@ -874,7 +872,6 @@ static int malidp_bind(struct device *dev)
> vblank_fail:
> malidp_se_irq_fini(hwdev);
> malidp_de_irq_fini(hwdev);
> - drm->irq_enabled = false;
> irq_init_fail:
> drm_atomic_helper_shutdown(drm);
> component_unbind_all(dev, drm);
> @@ -909,7 +906,6 @@ static void malidp_unbind(struct device *dev)
> drm_atomic_helper_shutdown(drm);
> malidp_se_irq_fini(hwdev);
> malidp_de_irq_fini(hwdev);
> - drm->irq_enabled = false;
> component_unbind_all(dev, drm);
> of_node_put(malidp->crtc.port);
> malidp->crtc.port = NULL;
> --
> 2.32.0
>
--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯
More information about the Linux-rockchip
mailing list