[RESEND PATCH v4 06/10] dt-bindings: gpio: change items restriction of clock for rockchip, gpio-bank

[Heiko Stübner]

Hi Jay,

Am Freitag, 18. Juni 2021, 08:41:45 CEST schrieb jay.xu at rock-chips.com:
> Hi Heiko
> 
> --------------
> jay.xu at rock-chips.com
> >Hi,
> >
> >Am Donnerstag, 13. Mai 2021, 08:46:06 CEST schrieb cl at rock-chips.com:
> >> From: Liang Chen <cl at rock-chips.com>
> >>
> >> The clock property need 2 items on some rockchip chips.
> >>
> >> Signed-off-by: Liang Chen <cl at rock-chips.com>
> >
> >this patch should definitly move over to Jianquns gpio driver series,
> >as it introduces the usage of these new clocks.
> >
> >Also while the single-clock variant definitly doesn't need it,
> >I think we may want clock-names "apb_pclk", "debounce-ref" for the
> >2-clock variants?
> > 
> Okay, I think it's very good idea, 
> but is it possible to post the reg-name patch after these dts serial and gpio serial patches ?

You're already creating a new binding when changing the max-items.
So when we change that again later, in theory you'd need to support both
cases (with and without clock-names)

So I'd really prefer to get the binding right the first time and
identifying multiple clocks by clock-names instead of an implicit ordering
is way better in the long run as well.

Heiko




> 
> >
> >Heiko
> >
> >> ---
> >>  Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml | 5 ++++-
> >>  1 file changed, 4 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml b/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml
> >> index d993e00..0d62c28 100644
> >> --- a/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml
> >> +++ b/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml
> >> @@ -22,7 +22,10 @@ properties:
> >>      maxItems: 1
> >> 
> >>    clocks:
> >> -    maxItems: 1
> >> +    minItems: 1
> >> +    items:
> >> +      - description: APB interface clock source
> >> +      - description: GPIO debounce reference clock source
> >> 
> >>    gpio-controller: true
> >> 
> >>
> >
> >
> >
> >
> >
> >
> >
>