[PATCH v6 0/7] rkisp1 support for px30

[Laurent Pinchart]

Hi Heiko,

On Fri, Jun 18, 2021 at 03:02:28PM +0200, Heiko Stuebner wrote:
> This series adds support for the slightly different v12
> variant of the ISP used for example in the px30 soc.

Nice :-)

How have you tested this ?

> changes in v6:
> - camera compatible in px30 binding example (Rob's bot)
> - move a last wrong positionen constant define (a v12 addition
>   should not be added in the v10-prefix change) (Dafna)
> - rename size to clk_size in match-data struct (Dafna)
> 
> changes in v5:
> - handle interrupt-names as conditional required property (Dafna)
> - add second example for showing interrupt-names (Dafna)
> 
> changes in v4:
> - clean up multi-irq case (Dafna)
>   Now each variant can have a list of interrupts
>   and their respective handlers, with or without
>   interrupt-names
> 
> changes in v3:
> - add necessary binding additions
> - fix pclk naming in binding
> - move v12 clk_ctrl register bits to v12 addition patch
> - fix rebase artefact with hst_enable
> 
> changes in v2 (from rfc):
> - split out phy patch into a separate series
> - drop dts patches for now
> - split v12 addition and v10 prefixes into separate patches
>   to enable easier review (Dafna)
> - remove {stats,params}_config structs, we can just use the
>   correct constant (Dafna)
> - adapt to styling comments from Dafna and Helen
> - add patch to remove the unused irq variable in struct rkisp
> 
> Heiko Stuebner (10):
>   media: rockchip: rkisp1: remove unused irq variable
>   dt-bindings: media: rkisp1: fix pclk clock-name
>   dt-bindings: media: rkisp1: document different irq possibilities
>   media: rockchip: rkisp1: allow separate interrupts
>   media: rockchip: rkisp1: make some isp-param functions variable
>   media: rockchip: rkisp1: make some isp-stats functions variable
>   media: rockchip: rkisp1: add prefixes for v10 specific parts
>   media: rockchip: rkisp1: add support for v12 isp variants
>   dt-bindings: media: rkisp1: document px30 isp compatible
>   media: rockchip: rkisp1: add support for px30 isp version
> 
>  .../bindings/media/rockchip-isp1.yaml         | 114 +++-
>  .../platform/rockchip/rkisp1/rkisp1-capture.c |   9 +-
>  .../platform/rockchip/rkisp1/rkisp1-common.h  |  44 +-
>  .../platform/rockchip/rkisp1/rkisp1-dev.c     |  81 ++-
>  .../platform/rockchip/rkisp1/rkisp1-isp.c     |  29 +-
>  .../platform/rockchip/rkisp1/rkisp1-params.c  | 557 ++++++++++++++----
>  .../platform/rockchip/rkisp1/rkisp1-regs.h    | 406 ++++++++-----
>  .../platform/rockchip/rkisp1/rkisp1-stats.c   | 107 +++-
>  8 files changed, 1050 insertions(+), 297 deletions(-)

-- 
Regards,

Laurent Pinchart