[PATCH v3 2/2] media: rockchip: rkisp1: extend uapi array sizes

Dafna Hirschfeld dafna.hirschfeld at collabora.com
Fri Jan 15 08:20:22 EST 2021



Am 15.01.21 um 13:21 schrieb Ezequiel Garcia:
> On Fri, 2021-01-15 at 12:23 +0100, Heiko Stuebner wrote:
>> From: Heiko Stuebner <heiko.stuebner at theobroma-systems.com>
>>
>> Later variants of the rkisp1 block use more entries in some arrays:
>>
>> RKISP1_CIF_ISP_AE_MEAN_MAX                 25 -> 81
>> RKISP1_CIF_ISP_HIST_BIN_N_MAX              16 -> 32
>> RKISP1_CIF_ISP_GAMMA_OUT_MAX_SAMPLES       17 -> 34
>> RKISP1_CIF_ISP_HISTOGRAM_WEIGHT_GRIDS_SIZE 28 -> 81
>>
>> and we can still extend the uapi during the 5.11-rc cycle, so do that
>> now to be on the safe side.
>>
>> V10 and V11 only need the smaller sizes, while V12 and V13 needed
>> the larger sizes.
>>
>> When adding the bigger sizes make sure, values filled from hardware
>> values and transmitted to userspace don't leak kernel data by zeroing
>> them beforehand.
>>
>> Signed-off-by: Heiko Stuebner <heiko.stuebner at theobroma-systems.com>
> 
> Reviewed-by: Ezequiel Garcia <ezequiel at collabora.com>

Reviewed-by: Dafna Hirschfeld <dafna.hirschfeld at collabora.com>

Thanks,
Dafna

> 
> Thanks,
> Ezequiel
> 



More information about the Linux-rockchip mailing list