[PATCH v2 0/2] Fix the rkisp1 userspace API for later IP versions
Heiko Stuebner
heiko at sntech.de
Thu Jan 14 18:33:40 EST 2021
This NEEDs to go into 5.11 while we can still adapt the uapi
during its RC-cycle.
When looking into supporting the rkisp1 of the px30 I noticed that
some fields got bigger in the uapi, caused by bigger number of samples
for example for histograms or gamma values.
The rkisp1 was destaged with 5.11-rc1 so we have still time during
the 5.11 cycle to fix that without big hassles.
This was discussed previously in a mail [0] and a rfc series [1]
and this two-part series now splits out the important parts that
really should become part of a 5.11-rc and thus the final 5.11.
changes since v1:
- drop duplicate isp_ver storage, hw_revision is enough
- document multiple maximum sizes in uapi
- document usage of hw_revision field
- zero fields transmitted to userspace before adding data
- use _V10 field sizes when filling fields, as there is only v10 for now
changes since rfc:
- move rkisp1_version enum into uapo
- show version in media-api hw_revision
- introduce constants for versions and make max use the biggest
[0] http://lore.kernel.org/r/3342088.iIbC2pHGDl@diego
[1] https://lore.kernel.org/r/20210108193311.3423236-2-heiko@sntech.de
Heiko Stuebner (2):
media: rockchip: rkisp1: carry ip version information
media: rockchip: rkisp1: extend uapi array sizes
Documentation/admin-guide/media/rkisp1.rst | 15 +++++++
.../platform/rockchip/rkisp1/rkisp1-dev.c | 21 +++++----
.../platform/rockchip/rkisp1/rkisp1-params.c | 2 +-
.../platform/rockchip/rkisp1/rkisp1-stats.c | 10 ++++-
include/uapi/linux/rkisp1-config.h | 43 ++++++++++++++++---
5 files changed, 74 insertions(+), 17 deletions(-)
--
2.29.2
More information about the Linux-rockchip
mailing list