[RFC PATCH] arm64: dts: rockchip: remove unused bus-scan-delay-ms from Pinebook Pro

Jari Hämäläinen nuumiofi at gmail.com
Fri Jan 1 10:18:45 EST 2021


bus-scan-delay-ms property is not used anywhere in the code. This was found
while preparing a workaround patch using equally named property for
RockPro64 [1] which uses the same RK3399 SoC as Pinebook Pro.

bus-scan-delay-ms might have been picked to Pinebook Pro DT from my earlier
patches for RockPro64 custom kernels like [2] or [3].

[1] https://lore.kernel.org/r/20201231125214.25733-1-nuumiofi@gmail.com
[2] https://github.com/nuumio/linux-kernel/commit/710570b8ad809bf3f162f8326
[3] https://github.com/nuumio/rp64-linux-mainline-kernel/commit/2bfc7d397f3

Signed-off-by: Jari Hämäläinen <nuumiofi at gmail.com>
---

Hello all,

Sending this as RFC because I don't have Pinebook Pro to test the cleaned
up DT and can only check that the change doesn't break the build. I did not
find any code reference to removed property and believe it has been
accidentally copied over, but there could always be some surpise.

Testing and comments how to proceed are welcome.

 arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts
index 06d48338c836..9589646824bf 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts
@@ -788,7 +788,6 @@ &pcie_phy {
 };
 
 &pcie0 {
-	bus-scan-delay-ms = <1000>;
 	ep-gpios = <&gpio2 RK_PD4 GPIO_ACTIVE_HIGH>;
 	max-link-speed = <2>;
 	num-lanes = <4>;

base-commit: f6e1ea19649216156576aeafa784e3b4cee45549
-- 
2.29.2




More information about the Linux-rockchip mailing list