[PATCH v2] mfd: rk808: add reboot support to rk808.c

[Peter Geis]

On Fri, Dec 17, 2021 at 1:30 PM Dmitry Osipenko <digetx at gmail.com> wrote:
>
> 17.12.2021 21:16, Peter Geis пишет:
> >>> +                     break;
> >>> +             default:
> >>> +                     dev_info(&client->dev, "pmic controlled board reset not supported\n");
>
> I'd change this dev_info to dev_dbg to not clutter KMSG.

I'd prefer to leave this as info, since the device is designated as
the system power controller but it is only capable of powering down
the system, not rebooting it.
But on second thought, anyone who's making these changes would be
investigating the driver anyway.
So I'll change it to dev_dbg.

>
> >> I'd set ret=0 explicitly here. Later on somebody may change the code and
> >> ret won't be zero anymore, this is not an uncommon trouble in kernel.
> > It took me a moment to see the logic here, but I understand it now.
> >
>
> Could be even better to place the error message simply right after the
> register_restart_handler().

Good point, thanks