[PATCH] ARM: dts: rockchip: remove cap-mmc-highspeed property from mk808 &mmc0 node

[Robin Murphy]

On 2021-08-20 15:41, Johan Jonker wrote:
> 
> 
> On 8/20/21 4:17 PM, Robin Murphy wrote:
>> On 2021-08-20 14:19, Johan Jonker wrote:
>>> On the MK808 only a microSD slot is connected with the SDMMC Host
>>> Controller,
>>> so remove the cap-mmc-highspeed property from the &mmc0 node.
>>
>> Why, does it do any harm?
> 
> Harm not. Example rk3066 u-boot:
> 
>>>>> sd_select_mode_and_width
> sd card: widths [4, 1, ] modes [MMC legacy, SD High Speed (50MHz), UHS
> SDR12 (25MHz), UHS SDR25 (50MHz), ]
> host: widths [4, 1, ] modes [MMC legacy, MMC High Speed (26MHz), SD
> High Speed (50MHz), MMC High Speed (52MHz), ]
> trying mode SD High Speed (50MHz) width 4 (at 50 MHz)
> 
> I would say only advertise host capabilities that are under normal
> circumstances occur. How realistic is it to use a TF/Micro SD TO SD Card
> Extension Cable Adapter (giggle) for a deprecated mmc card?

Well, if you want a far more realistic example:

https://www.hardkernel.com/shop/emmc-module-reader-board-for-os-upgrade/

Who are we to dictate what "normal circumstances" are, and what do we 
gain by removing support for modes that could work fine and at least be 
useful to someone on occasion?

Robin.