[PATCH v4 01/10] media: staging: rkisp1: cap: change RGB24 format to XBGR32
Dafna Hirschfeld
dafna.hirschfeld at collabora.com
Tue Sep 1 07:16:03 EDT 2020
According to the TRM [1], the YUV->RGB conversion outputs
RGB 888 format with 4 bytes, where the last byte is ignored,
using big endian representation:
|___X___|___R___|___G___|___B___|
31 24 16 8 0
Which matches format V4L2_PIX_FMT_XBGR32 in little endian
representation, so replace it accordingly.
"24 bit word". What it means is that 4 bytes are used with
24bit for the RGB and the last byte is ignored.
This matches format V4L2_PIX_FMT_XBGR32.
Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld at collabora.com>
Acked-by: Helen Koike <helen.koike at collabora.com>
Reviewed-by: Tomasz Figa <tfiga at chromium.org>
---
drivers/staging/media/rkisp1/rkisp1-capture.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/rkisp1/rkisp1-capture.c b/drivers/staging/media/rkisp1/rkisp1-capture.c
index 0632582a95b4..f4d5cc3e2f12 100644
--- a/drivers/staging/media/rkisp1/rkisp1-capture.c
+++ b/drivers/staging/media/rkisp1/rkisp1-capture.c
@@ -276,7 +276,7 @@ static const struct rkisp1_capture_fmt_cfg rkisp1_sp_fmts[] = {
},
/* rgb */
{
- .fourcc = V4L2_PIX_FMT_RGB24,
+ .fourcc = V4L2_PIX_FMT_XBGR32,
.write_format = RKISP1_MI_CTRL_SP_WRITE_PLA,
.output_format = RKISP1_MI_CTRL_SP_OUTPUT_RGB888,
}, {
--
2.17.1
More information about the Linux-rockchip
mailing list