Regression: HDMI stopped working on rk3399-sapphire in 4.17-rc1

[Vicente Bergas]

Hello,

On Fri, Apr 20, 2018 at 12:53 AM, Vicente Bergas <vicencb at gmail.com> wrote:
> Hi Heiko,
>
> On Fri, Apr 20, 2018 at 12:31 AM, Heiko Stuebner <heiko at sntech.de> wrote:
>> Hi Vicente,
>>
>> Am Dienstag, 17. April 2018, 19:23:29 CEST schrieb Vicente Bergas:
>>> On Mon, Apr 16, 2018 at 11:49 PM, Vicente Bergas <vicencb at gmail.com> wrote:
>>> > On Mon, Apr 16, 2018 at 11:41 PM, Heiko Stuebner <heiko at sntech.de> wrote:
>>> >> Hi Vicente,
>>> >>
>>> >> Am Montag, 16. April 2018, 23:18:27 CEST schrieb Vicente Bergas:
>>> >>> Hello,
>>> >>>
>>> >>> first of all, I am not sure if this goes to
>>> >>> linux-rockchip at lists.infradead.org
>>> >>> or
>>> >>> dri-devel at lists.freedesktop.org
>>> >>> Please, tell me if I have chosen the wrong list.
>>> >>
>>> >> Best would be having both in the Cc list :-)
>>> >>
>>> >>
>>> >>> In 4.16-rc7 the HDMI video works with minor issues, but it is perfectly
>>> >>> usable. In 4.17-rc1 the HDMI port is not detected at all.
>>> >>>
>>> >>> Here are the messages from dmesg that I think are relevant:
>>> >>>
>>> >>> Linux version 4.16.0-rc7+ (vj at alarm) (gcc version 7.3.0 (GCC)) #15 SMP
>>> >>> Mon Mar 26 19:03:44 CEST 2018
>>> >>> iommu: Adding device ff8f0000.vop to group 0
>>> >>> iommu: Adding device ff900000.vop to group 1
>>> >>> rockchip-drm display-subsystem: bound ff8f0000.vop (ops vop_component_ops)
>>> >>> rockchip-drm display-subsystem: bound ff900000.vop (ops vop_component_ops)
>>> >>> rockchip-drm display-subsystem: failed to bind ff940000.hdmi (ops
>>> >>> dw_hdmi_rockchip_ops): -EPROBE_DEFER
>>> >>> rockchip-drm display-subsystem: master bind failed: -EPROBE_DEFER
>>> >>> rockchip-drm display-subsystem: bound ff8f0000.vop (ops vop_component_ops)
>>> >>> rockchip-drm display-subsystem: bound ff900000.vop (ops vop_component_ops)
>>> >>> dwhdmi-rockchip ff940000.hdmi: Detected HDMI TX controller v2.11a with
>>> >>> HDCP (DWC HDMI 2.0 TX PHY)
>>> >>> rockchip-drm display-subsystem: bound ff940000.hdmi (ops dw_hdmi_rockchip_ops)
>>> >>> [drm] Supports vblank timestamp caching Rev 2 (21.10.2013).
>>> >>> [drm] No driver support for vblank timestamp query.
>>> >>> Console: switching to colour frame buffer device 240x67
>>> >>> rockchip-drm display-subsystem: fb0:  frame buffer device
>>> >>> [drm] Initialized rockchip 1.0.0 20140818 for display-subsystem on minor 0
>>> >>>
>>> >>> Linux version 4.17.0-rc1+ (vj at alarm) (gcc version 7.3.0 (GCC)) #1 SMP
>>> >>> Mon Apr 16 19:42:50 CEST 2018
>>> >>> rk_iommu ff8f3f00.iommu: Failed to get clk 'iface': -ENOENT
>>> >>> rk_iommu: probe of ff8f3f00.iommu failed with error -ENOENT
>>> >>> rk_iommu ff903f00.iommu: Failed to get clk 'iface': -ENOENT
>>> >>> rk_iommu: probe of ff903f00.iommu failed with error -ENOENT
>>> >>> rockchip-drm display-subsystem: Linked as a consumer to ff8f0000.vop
>>> >>> rockchip-drm display-subsystem: Linked as a consumer to ff900000.vop
>>> >>> rockchip-drm display-subsystem: Linked as a consumer to ff940000.hdmi
>>> >>> rockchip-drm display-subsystem: master bind failed: -12
>>> >>> rockchip-vop: probe of ff900000.vop failed with error -12
>>> >>>
>>> >>>
>>> >>> While fixing this issue, I can help debugging and testing.
>>> >>
>>> >> I do belive
>>> >>         https://patchwork.codeaurora.org/patch/495129/
>>> >> should do the trick. Needs a respin to make it a bit more
>>> >> beatiful, but should restore your display output again nevertheless.
>>> >>
>>> >>
>>> >> Heiko
>>> >
>>> > Hi Heiko,
>>> > thanks for such a quick answer!
>>> > Tomorrow I'll give it a try.
>>> >
>>> > Regards,
>>> >   Vicente.
>>>
>>> Hi Heiko,
>>> just tested your v2 patch:
>>> http://lists.infradead.org/pipermail/linux-rockchip/2018-April/020349.html
>>> and indeed the HDMI port was detected and was able to show me the console :)
>>>
>>> But, there have been several kernel stack traces, a lot of
>>> unresponsiveness and unable to start a framebuffer-based graphical
>>> mode.
>>> The first relevant error seems to be line 349 from dmesg:
>>> [CRTC:30:crtc-0] vblank wait timed out
>>> https://pastebin.com/YegEpAep
>>>
>>> Please, can somebody help?
>>
>> does the problem go away when you apply
>> https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=v4.18-armsoc/dts64&id=df3bcde704fb51645615635667944fc550c493e2
>>
>>
>> Thanks
>> Heiko
>
> Just tested, but unfortunately it does not fix the issue.
> The messages in dmesg are exactly the same except that these
>   rk_iommu ff8f3f00.iommu: Failed to get clk 'iface': -2
>   rk_iommu ff903f00.iommu: Failed to get clk 'iface': -2
> stopped appearing.
>
> Thank you,
>   Vicente.

like Jakob, I can also confirm that
https://patchwork.kernel.org/patch/10344875/
and
http://lists.infradead.org/pipermail/linux-rockchip/2018-April/020427.html
fixes the issue.

Thank you all!

Regards,
  Vicente.