[regression, bisected] rockchip rk3399 video output breakage

Jakob Unterwurzacher jakob.unterwurzacher at theobroma-systems.com
Tue Apr 24 06:47:35 PDT 2018


On 24.04.18 15:33, JeffyChen wrote:
>>> [   36.076577] WARNING: CPU: 1 PID: 83 at
>>> drivers/gpu/drm/rockchip/rockchip_drm_vop.c:1004
>>> vop_crtc_atomic_flush+0x1c0/0x1c8
> 
> this looks like an issue recently reported by heiko, we found that might 
> due to an unbalanced irq disable in vop driver.
> 
> my test patch is:
> 
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> @@ -1601,6 +1601,8 @@ static void vop_unbind(struct device *dev, struct 
> device *master, void *data)
>   {
>          struct vop *vop = dev_get_drvdata(dev);
> 
> +       // Pair with the initial disable_irq()
> +       enable_irq(vop->irq);
> 
> 
> 
> and i think sandy would send the real patch soon(maybe already sent?)

Works fine with your patch! Thank you very much Jeffy.

Best regards,
Jakob



More information about the Linux-rockchip mailing list