[PATCH] PCI: rockchip: Remove redundant "valid device" check
Bjorn Helgaas
helgaas at kernel.org
Fri Dec 15 12:29:35 PST 2017
From: Bjorn Helgaas <bhelgaas at google.com>
In rockchip_pcie_valid_device(), we do the exact same test twice:
if (bus->number == rockchip->root_bus_nr && dev > 0)
return 0;
if (bus->number == rockchip->root_bus_nr && dev > 0)
return 0;
We only need to do it once, so remove one of them.
Signed-off-by: Bjorn Helgaas <bhelgaas at google.com>
---
drivers/pci/host/pcie-rockchip.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/pci/host/pcie-rockchip.c b/drivers/pci/host/pcie-rockchip.c
index 9051c6c8fea4..dd9c7ea69e0b 100644
--- a/drivers/pci/host/pcie-rockchip.c
+++ b/drivers/pci/host/pcie-rockchip.c
@@ -293,10 +293,6 @@ static void rockchip_pcie_update_txcredit_mui(struct rockchip_pcie *rockchip)
static int rockchip_pcie_valid_device(struct rockchip_pcie *rockchip,
struct pci_bus *bus, int dev)
{
- /* access only one slot on each root port */
- if (bus->number == rockchip->root_bus_nr && dev > 0)
- return 0;
-
/*
* do not read more than one device on the bus directly attached
* to RC's downstream side.
More information about the Linux-rockchip
mailing list