[PATCH] net: ethernet: arc: fix error handling in emac_rockchip_probe

David Miller davem at davemloft.net
Thu Dec 7 10:52:07 PST 2017


From: Branislav Radocaj <branislav at radocaj.org>
Date: Thu,  7 Dec 2017 00:07:38 +0100

> If clk_set_rate() fails, we should disable clk before return.
> Found by Linux Driver Verification project (linuxtesting.org).
> 
> Signed-off-by: Branislav Radocaj <branislav at radocaj.org>

Ok, but this probe routine is very inconsistent in how it handles
clock rate setting failures now.

Above your changes, if the RGMII clk can't have it's rate set, we
just continue.



More information about the Linux-rockchip mailing list