[PATCH] PCI: rockchip: manipulate phy properly if failing to probe the driver

Bjorn Helgaas helgaas at kernel.org
Wed Aug 23 09:57:29 PDT 2017


On Wed, Aug 23, 2017 at 09:03:04AM +0800, Shawn Lin wrote:
> Hi Bjorn,
> 
> On 2017/8/23 4:47, Bjorn Helgaas wrote:
> >On Wed, Aug 09, 2017 at 07:14:23PM +0800, Shawn Lin wrote:
> >>We observed that the clk_pciephy_ref is still enabled when we actually
> >>fail to probe the driver.
> >>
> >>root at linaro-alip:~# cat /sys/kernel/debug/clk/clk_summary | grep pcie
> >>clk_pciephy_ref			  1	1	 24000000	0 0
> >>clk_pcie_pm			  0	0	 24000000	0 0
> >>       clk_pcie_core_cru           0	0	125000000	0 0
> >>       clk_pciephy_ref100m         0	0	100000000	0 0
> >>		aclk_pcie         0	0	148500000	0 0
> >>		aclk_perf_pcie    0	0	148500000	0 0
> >>			pclk_pcie 0	0	 37125000	0 0
> >>clk_pcie_core                     0	0		0	0 0
> >>
> >>clk_pciephy_ref is used by phy driver and we need to properly disable
> >>it for this case. So this patch add error handle for the function of
> >>rockchip_pcie_init_port to fix this issue.
> >>
> >>Signed-off-by: Shawn Lin <shawn.lin at rock-chips.com>
> >
> >Applied to pci/host-rockchip for v4.14, thanks!
> 
> I actually posted a v2 sometime ago, so could you please drop this one?

Oops, sorry.  I dropped this one and will pick it up from the new v5 series
you posted.

Bjorn



More information about the Linux-rockchip mailing list