media: rockchip-vpu: I should place the huffman table at kernel or userspace ?

[Hans Verkuil]

On 27/09/16 05:43, Randy Li wrote:
> Hello:
>   I have just done a JPEG HW encoder for the RK3288. I have been told
> that I can't use the standard way to generate huffman table, the VPU
> supports only 10 levels with a different huffman table.
>   If I send the huffman table through the v4l2 extra control, the memory
> copy is requested, although the data is not very large(2 x 64 bytes) but
> still a overhead. The other way is to place them in the kernel driver,
> and just define the quality every time it encode a picture. But storing
> in kernel would make the driver a little bigger(2 x 11 x 64 bytes) and
> beyond the FIFO job.
>   So where Should I place the huffman table?

Put it in the driver. It's less than 1.5 kB, so really small.

I'm not sure what you mean with 'beyond the FIFO job' though.

My understanding is that there 10 quality levels, each with its own 
huffman table?

So the driver would implement the V4L2_CID_JPEG_COMPRESSION_QUALITY control
and for each quality level it picks a table. Makes sense to me.

Regards,

	Hans