[PATCH v5 3/5] mmc: core: implement enhanced strobe support
Doug Anderson
dianders at chromium.org
Mon May 23 17:39:32 PDT 2016
Shawn,
On Sun, May 22, 2016 at 9:13 PM, Shawn Lin <shawn.lin at rock-chips.com> wrote:
> Controllers use data strobe line to latch data from devices
> under hs400 mode, but not for cmd line. So since emmc 5.1, JEDEC
> introduces enhanced strobe mode for latching cmd response from
> emmc devices to host controllers. This new feature is optional,
> so it depends both on device's cap and host's cap to decide
> whether to use it or not.
>
> Signed-off-by: Shawn Lin <shawn.lin at rock-chips.com>
> ---
>
> Changes in v5: None
> Changes in v4: None
Not terribly important, but things certainly did change in this patch
since previous versions.
> Changes in v3: None
> Changes in v2: None
>
> drivers/mmc/core/bus.c | 3 +-
> drivers/mmc/core/core.c | 9 ++++++
> drivers/mmc/core/mmc.c | 84 ++++++++++++++++++++++++++++++++++++++++++++++--
> include/linux/mmc/card.h | 1 +
> include/linux/mmc/host.h | 11 +++++++
> include/linux/mmc/mmc.h | 3 ++
> 6 files changed, 108 insertions(+), 3 deletions(-)
I don't see anything obviously bad about this patch, but I haven't
gone deep into all the details of mmc_select_hs400es(), so I'm not
sure I can really provide a full Reviewed tag. At least I have tested
this, so:
Tested-by: Douglas Anderson <dianders at chromium.org>
More information about the Linux-rockchip
mailing list