[PATCH 1/4] ARM: multi_v7_defconfig: Enable common Rockchip devices/busses

Sjoerd Simons sjoerd.simons at collabora.co.uk
Mon Sep 7 03:24:27 PDT 2015


On Mon, 2015-09-07 at 11:26 +0200, Javier Martinez Canillas wrote:
> Hello Sjoerd,
> 
> On 09/06/2015 10:16 PM, Sjoerd Simons wrote:
> > Enable Rockchip I2C, SPI, PWM, thermal drivers.
> > 
> > Builtin are:
> >  * I2C as it often controls the pmic.
> 
> Having I2C as a module will cause more probe deferrals due missing
> regulators and slow down the boot but it should not cause issues.
> Or am I missing something?
> 
> In fact, I think even the PMIC could be built as a module.

It could in principle. However as a lot of other drivers do need the
regulators provided by the pmic, they'll be deferred until that driver
is loaded. So e.g. with the i2c/pmic drivers as a module you cannot
boot to an NFS rootfs without using an initramfs. 

> But I don't have a strong opinion on this so patch looks good:
> 
> Reviewed-by: Javier Martinez Canillas <javier at osg.samsung.com>
> 
> Best regards,

-- 
Sjoerd Simons <sjoerd.simons at collabora.co.uk>
Collabora Ltd.



More information about the Linux-rockchip mailing list