[PATCH] crypto: rockchip/crypto - fix possible deadlock

Herbert Xu herbert at gondor.apana.org.au
Sat Nov 28 00:57:08 PST 2015


On Sat, Nov 28, 2015 at 01:48:53AM +0100, Heiko Stübner wrote:
>
> @@ -169,9 +169,10 @@ static irqreturn_t rk_crypto_irq_handle(int irq, void *dev_id)
>  {
>  	struct rk_crypto_info *dev  = platform_get_drvdata(dev_id);
>  	u32 interrupt_status;
> +	unsigned long flags;
>  	int err = 0;
>  
> -	spin_lock(&dev->lock);
> +	spin_lock_irqsave(&dev->lock, flags);

You don't need to disable IRQs in an IRQ handler.

Thanks,
-- 
Email: Herbert Xu <herbert at gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt



More information about the Linux-rockchip mailing list