poweroff-issue with dwc2 on Felipe's testing/next branch
Felipe Balbi
balbi at ti.com
Wed Dec 16 09:39:54 PST 2015
Hi,
Doug Anderson <dianders at chromium.org> writes:
>>>> it seems the recent dwc2 additions to the testing/next branch [0] caused
>>>> some interesting issue for me.
>>>>
>>>> Setting is a regular 4.4-rc3/4 (only with some display-stuff added), and the
>>>> testing/next branch merged in.
>>>>
>>>> If I attach a single usb device everything still works fine, but once it
>>>> is connected through a hub, like the following:
>>>>
>>>> root at localhost:~# lsusb -t
>>>> /: Bus 02.Port 1: Dev 1, Class=root_hub, Driver=ehci-platform/1p, 480M
>>>> |__ Port 1: Dev 2, If 0, Class=Video, Driver=, 480M
>>>> |__ Port 1: Dev 2, If 1, Class=Video, Driver=, 480M
>>>> /: Bus 01.Port 1: Dev 1, Class=root_hub, Driver=dwc2/1p, 480M
>>>> |__ Port 1: Dev 2, If 0, Class=Hub, Driver=hub/5p, 480M
>>>> |__ Port 1: Dev 3, If 0, Class=Vendor Specific Class, Driver=smsc95xx, 480M
>>>> |__ Port 2: Dev 4, If 0, Class=Mass Storage, Driver=usb-storage, 480M
>>>>
>>>> I get strange results when powering off the device with the usb device
>>>> still attached.
>>>>
>>>> On regular 4.4-rc3
>>>> root at localhost:~# poweroff
>>>> ...
>>>> reboot: Power down
>>>> ~20sec delay before actual poweroff
>>>> [that delay is only present with a usb hub in between, probably due to the
>>>> big number of interrupts it creates]
>>>>
>>>>
>>>> With testing/next the device cannot poweroff anymore and instead I get
>>>> [ 40.117160] reboot: Power down
>>>> [ 68.031372] NMI watchdog: BUG: soft lockup - CPU#0 stuck for 22s! [systemd-shutdow:1]
>>>> [ 68.046575] Modules linked in:
>>>> [ 68.053084] irq event stamp: 1654975
>>>> [ 68.060091] hardirqs last enabled at (1654974): [<c00156fc>] __irq_svc+0x5c/0x78
>>>> [ 68.074935] hardirqs last disabled at (1654975): [<c00156e8>] __irq_svc+0x48/0x78
>>>> [ 68.089666] softirqs last enabled at (1654846): [<c002ef84>] __do_softirq+0x358/0x49c
>>>> [ 68.105261] softirqs last disabled at (1654847): [<c002f400>] irq_exit+0x94/0xd4
>>>> [ 68.120027] CPU: 0 PID: 1 Comm: systemd-shutdow Not tainted 4.4.0-rc4+ #2761
>>>> [ 68.133507] Hardware name: Rockchip (Device Tree)
>>>> [ 68.142690] task: ee900d40 ti: ee902000 task.ti: ee902000
>>>> [ 68.153237] PC is at rcu_lockdep_current_cpu_online+0x6c/0x90
>>>> [ 68.164438] LR is at rcu_read_lock_held+0x38/0x58
>>>> [ 68.173683] pc : [<c0095e98>] lr : [<c0094d00>] psr: 00010113
>>>> [ 68.173683] sp : ee903be8 ip : ee903bf8 fp : ee903bf4
>>>> [ 68.195300] r10: c0b884f8 r9 : 00000000 r8 : c0b884f8
>>>> [ 68.205429] r7 : ffffbccc r6 : eed7f680 r5 : 00000001 r4 : ee955800
>>>> [ 68.217938] r3 : ee902028 r2 : 0000000f r1 : c0b1891c r0 : 00000001
>>>> [ 68.230482] Flags: nzcv IRQs on FIQs on Mode SVC_32 ISA ARM Segment none
>>>> [ 68.244141] Control: 10c5387d Table: 2dae806a DAC: 00000051
>>>> [ 68.255283] CPU: 0 PID: 1 Comm: systemd-shutdow Not tainted 4.4.0-rc4+ #2761
>>>> [ 68.268720] Hardware name: Rockchip (Device Tree)
>>>> [ 68.278165] [<c0019914>] (unwind_backtrace) from [<c0014bcc>] (show_stack+0x20/0x24)
>>>> [ 68.293198] [<c0014bcc>] (show_stack) from [<c02c4584>] (dump_stack+0x84/0xb8)
>>>> [ 68.307285] [<c02c4584>] (dump_stack) from [<c0010d74>] (show_regs+0x1c/0x20)
>>>> [ 68.321205] [<c0010d74>] (show_regs) from [<c00d993c>] (watchdog_timer_fn+0x1c8/0x250)
>>>> [ 68.336579] [<c00d993c>] (watchdog_timer_fn) from [<c00a0e0c>] (__hrtimer_run_queues+0x2cc/0x55c)
>>>> [ 68.353819] [<c00a0e0c>] (__hrtimer_run_queues) from [<c00a12a0>] (hrtimer_interrupt+0xac/0x1f8)
>>>> [ 68.370795] [<c00a12a0>] (hrtimer_interrupt) from [<c04f1714>] (arch_timer_handler_phys+0x38/0x48)
>>>> [ 68.388044] [<c04f1714>] (arch_timer_handler_phys) from [<c008fd34>] (handle_percpu_devid_irq+0x15c/0x314)
>>>> [ 68.406687] [<c008fd34>] (handle_percpu_devid_irq) from [<c008b4b8>] (generic_handle_irq+0x28/0x38)
>>>> [ 68.424177] [<c008b4b8>] (generic_handle_irq) from [<c008b830>] (__handle_domain_irq+0x9c/0xc4)
>>>> [ 68.440945] [<c008b830>] (__handle_domain_irq) from [<c0009518>] (gic_handle_irq+0x58/0x80)
>>>> [ 68.457054] [<c0009518>] (gic_handle_irq) from [<c00156f8>] (__irq_svc+0x58/0x78)
>>>> [ 68.471405] Exception stack(0xee903b98 to 0xee903be0)
>>>> [ 68.481288] 3b80: 00000001 c0b1891c
>>>> [ 68.497074] 3ba0: 0000000f ee902028 ee955800 00000001 eed7f680 ffffbccc c0b884f8 00000000
>>>> [ 68.512875] 3bc0: c0b884f8 ee903bf4 ee903bf8 ee903be8 c0094d00 c0095e98 00010113 ffffffff
>>>> [ 68.528713] [<c00156f8>] (__irq_svc) from [<c0095e98>] (rcu_lockdep_current_cpu_online+0x6c/0x90)
>>>> [ 68.545915] [<c0095e98>] (rcu_lockdep_current_cpu_online) from [<c0094d00>] (rcu_read_lock_held+0x38/0x58)
>>>> [ 68.564535] [<c0094d00>] (rcu_read_lock_held) from [<c006af0c>] (run_rebalance_domains+0x114/0x3e4)
>>>> [ 68.582013] [<c006af0c>] (run_rebalance_domains) from [<c002ee04>] (__do_softirq+0x1d8/0x49c)
>>>> [ 68.598529] [<c002ee04>] (__do_softirq) from [<c002f400>] (irq_exit+0x94/0xd4)
>>>> [ 68.612591] [<c002f400>] (irq_exit) from [<c008b834>] (__handle_domain_irq+0xa0/0xc4)
>>>> [ 68.808119] [<c008b834>] (__handle_domain_irq) from [<c0009518>] (gic_handle_irq+0x58/0x80)
>>>> [ 69.004792] [<c0009518>] (gic_handle_irq) from [<c00156f8>] (__irq_svc+0x58/0x78)
>>>> [ 69.203767] Exception stack(0xee903d20 to 0xee903d68)
>>>> [ 69.402232] 3d20: 00000001 00000010 c134e8f8 ee900d40 00000000 60010013 ee26a834 00000000
>>>> [ 69.608139] 3d40: 00000000 00000000 00000000 ee903db4 00000002 ee903d70 ee9012a8 c007f4bc
>>>> [ 69.811985] 3d60: 80010013 ffffffff
>>>> [ 70.007318] [<c00156f8>] (__irq_svc) from [<c007f4bc>] (lock_acquire+0x190/0x218)
>>>> [ 70.212947] [<c007f4bc>] (lock_acquire) from [<c0758f5c>] (mutex_lock_nested+0x78/0x41c)
>>>> [ 70.419796] [<c0758f5c>] (mutex_lock_nested) from [<c03d5838>] (regmap_lock_mutex+0x1c/0x20)
>>>> [ 70.630771] [<c03d5838>] (regmap_lock_mutex) from [<c03d8e6c>] (regmap_update_bits+0x34/0x70)
>>>> [ 70.842523] [<c03d8e6c>] (regmap_update_bits) from [<c03e5a4c>] (rk808_device_shutdown+0x4c/0x74)
>>>> [ 71.056896] [<c03e5a4c>] (rk808_device_shutdown) from [<c0012bc8>] (machine_power_off+0x34/0x3c)
>>>> [ 71.271604] [<c0012bc8>] (machine_power_off) from [<c004f3d4>] (kernel_power_off+0x6c/0x80)
>>>> [ 71.486193] [<c004f3d4>] (kernel_power_off) from [<c004f588>] (SyS_reboot+0x148/0x1d8)
>>>> [ 71.701543] [<c004f588>] (SyS_reboot) from [<c000ff80>] (ret_fast_syscall+0x0/0x1c)
>>>> [ 71.920475] Kernel panic - not syncing: softlockup: hung tasks
>>>> [ 72.134543] CPU: 0 PID: 1 Comm: systemd-shutdow Tainted: G L 4.4.0-rc4+ #2761
>>>> [ 72.353754] Hardware name: Rockchip (Device Tree)
>>>> [ 72.567683] [<c0019914>] (unwind_backtrace) from [<c0014bcc>] (show_stack+0x20/0x24)
>>>> [ 72.789719] [<c0014bcc>] (show_stack) from [<c02c4584>] (dump_stack+0x84/0xb8)
>>>> [ 73.012087] [<c02c4584>] (dump_stack) from [<c01157e4>] (panic+0x9c/0x210)
>>>> [ 73.233823] [<c01157e4>] (panic) from [<c00d9984>] (watchdog_timer_fn+0x210/0x250)
>>>> [ 73.456871] [<c00d9984>] (watchdog_timer_fn) from [<c00a0e0c>] (__hrtimer_run_queues+0x2cc/0x55c)
>>>> [ 73.683212] [<c00a0e0c>] (__hrtimer_run_queues) from [<c00a12a0>] (hrtimer_interrupt+0xac/0x1f8)
>>>> [ 73.909999] [<c00a12a0>] (hrtimer_interrupt) from [<c04f1714>] (arch_timer_handler_phys+0x38/0x48)
>>>> [ 74.137596] [<c04f1714>] (arch_timer_handler_phys) from [<c008fd34>] (handle_percpu_devid_irq+0x15c/0x314)
>>>> [ 74.367459] [<c008fd34>] (handle_percpu_devid_irq) from [<c008b4b8>] (generic_handle_irq+0x28/0x38)
>>>> [ 74.596433] [<c008b4b8>] (generic_handle_irq) from [<c008b830>] (__handle_domain_irq+0x9c/0xc4)
>>>> [ 74.826935] [<c008b830>] (__handle_domain_irq) from [<c0009518>] (gic_handle_irq+0x58/0x80)
>>>> [ 75.057263] [<c0009518>] (gic_handle_irq) from [<c00156f8>] (__irq_svc+0x58/0x78)
>>>> [ 75.285610] Exception stack(0xee903b98 to 0xee903be0)
>>>> [ 75.509201] 3b80: 00000001 c0b1891c
>>>> [ 75.737970] 3ba0: 0000000f ee902028 ee955800 00000001 eed7f680 ffffbccc c0b884f8 00000000
>>>> [ 75.965750] 3bc0: c0b884f8 ee903bf4 ee903bf8 ee903be8 c0094d00 c0095e98 00010113 ffffffff
>>>> [ 76.193210] [<c00156f8>] (__irq_svc) from [<c0095e98>] (rcu_lockdep_current_cpu_online+0x6c/0x90)
>>>> [ 76.422735] [<c0095e98>] (rcu_lockdep_current_cpu_online) from [<c0094d00>] (rcu_read_lock_held+0x38/0x58)
>>>> [ 76.654439] [<c0094d00>] (rcu_read_lock_held) from [<c006af0c>] (run_rebalance_domains+0x114/0x3e4)
>>>> [ 76.885606] [<c006af0c>] (run_rebalance_domains) from [<c002ee04>] (__do_softirq+0x1d8/0x49c)
>>>> [ 77.116138] [<c002ee04>] (__do_softirq) from [<c002f400>] (irq_exit+0x94/0xd4)
>>>> [ 77.342544] [<c002f400>] (irq_exit) from [<c008b834>] (__handle_domain_irq+0xa0/0xc4)
>>>> [ 77.569812] [<c008b834>] (__handle_domain_irq) from [<c0009518>] (gic_handle_irq+0x58/0x80)
>>>> [ 77.801452] [<c0009518>] (gic_handle_irq) from [<c00156f8>] (__irq_svc+0x58/0x78)
>>>> [ 78.030528] Exception stack(0xee903d20 to 0xee903d68)
>>>> [ 78.254326] 3d20: 00000001 00000010 c134e8f8 ee900d40 00000000 60010013 ee26a834 00000000
>>>> [ 78.483633] 3d40: 00000000 00000000 00000000 ee903db4 00000002 ee903d70 ee9012a8 c007f4bc
>>>> [ 78.710987] 3d60: 80010013 ffffffff
>>>> [ 78.929606] [<c00156f8>] (__irq_svc) from [<c007f4bc>] (lock_acquire+0x190/0x218)
>>>> [ 79.156074] [<c007f4bc>] (lock_acquire) from [<c0758f5c>] (mutex_lock_nested+0x78/0x41c)
>>>> [ 79.383616] [<c0758f5c>] (mutex_lock_nested) from [<c03d5838>] (regmap_lock_mutex+0x1c/0x20)
>>>> [ 79.611793] [<c03d5838>] (regmap_lock_mutex) from [<c03d8e6c>] (regmap_update_bits+0x34/0x70)
>>>> [ 79.839125] [<c03d8e6c>] (regmap_update_bits) from [<c03e5a4c>] (rk808_device_shutdown+0x4c/0x74)
>>>> [ 80.066755] [<c03e5a4c>] (rk808_device_shutdown) from [<c0012bc8>] (machine_power_off+0x34/0x3c)
>>>> [ 80.296308] [<c0012bc8>] (machine_power_off) from [<c004f3d4>] (kernel_power_off+0x6c/0x80)
>>>> [ 80.525430] [<c004f3d4>] (kernel_power_off) from [<c004f588>] (SyS_reboot+0x148/0x1d8)
>>>> [ 80.753737] [<c004f588>] (SyS_reboot) from [<c000ff80>] (ret_fast_syscall+0x0/0x1c)
>>>> [ 80.986626] ---[ end Kernel panic - not syncing: softlockup: hung tasks
>>>>
>>>>
>>>> There are more pending patches I haven't looked at - so maybe one of them
>>>> improves that, but maybe one of you also has some idea :-) .
>>>>
>>>>
>>>> Heiko
>>>>
>>>>
>>>> [0] https://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/log/?h=testing/next
>>>>
>>>>
>>>
>>>
>>> Hi Heiko,
>>>
>>> Felipe's testing/next tree has some commits on it that I found
>>> problems with and that I'm reworking now. I'm not sure if anything
>>> there is related.
>>>
>>> You can try from commit a105c257 to see if it resolves it. Or you can
>>> wait until I resubmit those patches.
>>
>> I can drop them, which ones should I drop ?
>
> I can reproduce similar hangs on Heiko's "somewhat-stable" tree even
> without usb-next if I use his kernel config. I can't with my kernel
> config. I'm digging a little, but my initial thought is that John's
> series is not to blame.
>
> Also: I though that you were going to drop John's patches anyway since
> he was planning to repost them? See
> <http://article.gmane.org/gmane.linux.usb.general/135193> Presumably
> those would be:
>
> John Youn (12):
> usb: dwc2: Reorder AHBIDLE and CSFTRST in dwc2_core_reset()
> usb: dwc2: Rename dwc2_core_reset()
> usb: dwc2: Add dwc2_core_reset()
> usb: dwc2: Add functions to check the HW OTG config
> usb: dwc2: Fix dr_mode validation
> usb: dwc2: Move mode querying functions into core.h
> usb: dwc2: Move reset into dwc2_get_hwparams()
> usb: dwc2: Add functions to set and clear force mode
> usb: dwc2: Improve handling of host and device hwparams
> usb: dwc2: gadget: Use the common dwc2_core_reset()
> usb: dwc2: gadget: Remove force device mode
> usb: dwc2: Reduce delay when forcing mode in reset
yeah, already dropped :-) Check testing/next :-)
cheers
--
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-rockchip/attachments/20151216/cbdcf213/attachment.sig>
More information about the Linux-rockchip
mailing list