[PATCH v2 2/9] i2c: add generic routine to parse DT for timing information

Mika Westerberg mika.westerberg at linux.intel.com
Tue Dec 8 03:09:44 PST 2015

On Tue, Dec 08, 2015 at 10:37:46AM +0100, Wolfram Sang wrote:
> From: Wolfram Sang <wsa+renesas at sang-engineering.com>
> Inspired from the i2c-rk3x driver (thanks guys!) but refactored and
> extended. See built-in docs for further information.
> Signed-off-by: Wolfram Sang <wsa+renesas at sang-engineering.com>

Looks good. I think we can take advantage of this in the designware
driver as well.

Reviewed-by: Mika Westerberg <mika.westerberg at linux.intel.com>

I wonder if it makes sense to add "i2c-sda-hold-time-ns" (taken from the
designware driver DT binding) to the timings structure? It is tHD;DAT
parameter in the I2C bus specification.

More information about the Linux-rockchip mailing list