[PATCH 1/4] dt-bindings: riscv: thead: add Milk-V Meles
Krzysztof Kozlowski
krzk at kernel.org
Wed Sep 30 22:36:21 PDT 2026
On 30/09/2026 19:02, Drew Fustini wrote:
> On Wed, Sep 30, 2026 at 10:37:28PM +0800, Han Gao wrote:
>> On Wed, Sep 30, 2026 at 7:51 PM Krzysztof Kozlowski <krzk at kernel.org> wrote:
>>>
>>> On Tue, Sep 29, 2026 at 06:22:45PM +0800, Han Gao wrote:
>>>> Document the Milk-V Meles board compatible with the TH1520 fallback.
>>>>
>>>> Signed-off-by: Han Gao <gaohan at iscas.ac.cn>
>>>> ---
>>>> Documentation/devicetree/bindings/riscv/thead.yaml | 4 ++++
>>>> 1 file changed, 4 insertions(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/riscv/thead.yaml b/Documentation/devicetree/bindings/riscv/thead.yaml
>>>> index 301912dcd290e60f816d380152591106de9415b4..5361021b8dcc9897803a5915665c6bb83309fe53 100644
>>>> --- a/Documentation/devicetree/bindings/riscv/thead.yaml
>>>> +++ b/Documentation/devicetree/bindings/riscv/thead.yaml
>>>> @@ -21,6 +21,10 @@ properties:
>>>> items:
>>>> - const: beagle,beaglev-ahead
>>>> - const: thead,th1520
>>>> + - description: Milk-V Meles single board computer
>>>> + items:
>>>> + - const: milkv,meles
>>>
>>> Why isn't this enum with the previous entry?
>>
>> Merging will result in the loss of SBC manufacturer information.
>> Milk-V is an independent manufacturer.
>>
>> Thanks,
>> Han
>
> I think the feedback is that BeagleV Ahead and Milk-V Meles have the
> same pattern and it could be changed to:
>
> - description: TH1520 single board computers
> items:
> - enum:
> - beagle,beaglev-ahead
> - milkv,meles
> - const: thead,th1520
>
> Is that right, Krzysztof?
Yes, that's easier to maintain pattern. Entry per single board means 3
redundant lines and a lot of bloat. Only one or two SoCs follow such
approach.
Best regards,
Krzysztof
More information about the linux-riscv
mailing list