[PATCH 2/3] rtc: Add StarFive JH7110 RTC driver

Uwe Kleine-König u.kleine-koenig at baylibre.com
Sun Nov 8 00:37:34 PST 2026


Hello,

On Fri, Nov 06, 2026 at 05:55:59PM +0000, Owen O'Hehir wrote:
> +#include <linux/mod_devicetable.h>
> [...]
> +#include <linux/platform_device.h>

Please don't include <linux/mod_devicetable.h>. You can (and IMHO
should) assume that <linux/platform_device.h> does provide struct
of_device_id and just drop <linux/mod_devicetable.h>. If you insist on
IWYU, please use <linux/device-id/of.h> instead to not get a bunch of
unneeded dependencies.

Best regards
Uwe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-riscv/attachments/20261108/97b5d2d0/attachment.sig>


More information about the linux-riscv mailing list