[PATCH v2 1/1] spi: use dmaengine_desc_set_callback()

Geert Uytterhoeven geert at linux-m68k.org
Thu Nov 5 01:20:03 PST 2026


Hi Frank,

On Wed, 4 Nov 2026 at 16:30, <Frank.Li at oss.nxp.com> wrote:
> From: Frank Li <Frank.Li at nxp.com>
>
> Replace open-coded assignments to callback and callback_param fields
> of struct dma_async_tx_descriptor with calls to the
> dmaengine_desc_set_callback() helper across SPI bus drivers.
>
> No functional change intended. Prepare make to struct
> dma_async_tx_descriptor private to the DMA engine.
>
> Reviewed-by: Linus Walleij <linusw at kernel.org>
> Reviewed-by: Mukesh Kumar Savaliya <mukesh.savaliya at oss.qualcomm.com>
> Acked-by: Alain Volmat <alain.volmat at foss.st.com>
> Reviewed-by: Wolfram Sang <wsa+renesas at sang-engineering.com>
> Reviewed-by: Troy Mitchell <troy.mitchell at linux.spacemit.com>
> Reviewed-by: Kunihiko Hayashi <hayashi.kunihiko at socionext.com>
> Acked-by: Thierry Reding <treding at nvidia.com>
> Signed-off-by: Frank Li <Frank.Li at nxp.com>
> ---
> change in v2
> - add missed set_callback in rspi_dma_transfer() (sashiko
> - collect review by tags
> - drop void *

You have lost the "# Renesas related drivers" part from Wolfram's
review?
https://lore.kernel.org/all/auoQiuIm9FxdOrYl@shikoro/



Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



More information about the linux-riscv mailing list