[PATCH v4] riscv: dts: spacemit: Add ethernet device for K3
Yixun Lan
dlan at kernel.org
Mon Mar 23 23:19:27 PDT 2026
Hi Inochi,
thanks for the patch, I have few minor comments below..
On 06:15 Tue 24 Mar , Inochi Amaoto wrote:
> Add all ethernet device nodes for K3 SoC.
>
> Signed-off-by: Inochi Amaoto <inochiama at gmail.com>
> ---
> Require the following patch series:
> 1. Basic DT device patch
> https://lore.kernel.org/spacemit/20260304-01-dts-uart-full-v1-0-50a0aa53a245@kernel.org
> 2. Ethernet driver patch
> https://lore.kernel.org/spacemit/20260316010041.164360-1-inochiama@gmail.com
>
> Changed from v3:
> 1. Separate the pin as RGMII pin and INT pin.
> 2. Add comment for pin usage.
> 3. Rename the ethernet pinctrl node to address it is RGMII node.
>
> Changed from v2:
> 1. keep aliases in alphabetical order.
>
> Changed from v1:
> 1. remove interrupt-parents property
> 2. add aliases for ethernet node
> ---
> arch/riscv/boot/dts/spacemit/k3-pico-itx.dts | 24 +++++
> arch/riscv/boot/dts/spacemit/k3-pinctrl.dtsi | 44 ++++++++
> arch/riscv/boot/dts/spacemit/k3.dtsi | 104 +++++++++++++++++++
> 3 files changed, 172 insertions(+)
> create mode 100644 arch/riscv/boot/dts/spacemit/k3-pinctrl.dtsi
>
> diff --git a/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts b/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts
> index b691304d4b74..b63d86b72be6 100644
> --- a/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts
> +++ b/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts
> @@ -4,13 +4,19 @@
> * Copyright (c) 2026 Guodong Xu <guodong at riscstar.com>
> */
>
> +#include <dt-bindings/gpio/gpio.h>
> +
> #include "k3.dtsi"
> +#include "k3-pinctrl.dtsi"
>
> / {
> model = "SpacemiT K3 Pico-ITX";
> compatible = "spacemit,k3-pico-itx", "spacemit,k3";
>
> aliases {
> + ethernet0 = ð0;
..
> + ethernet1 = ð1;
> + ethernet2 = ð2;
I insist not to add the alias if the device is disabled..
> serial0 = &uart0;
> };
>
> @@ -24,6 +30,24 @@ memory at 100000000 {
> };
> };
>
> +ð0 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&gmac0_rgmii_0_cfg>, <&gmac0_phy_0_cfg>;
> + phy-mode = "rgmii-id";
> + phy-handle = <&phy0>;
> + status = "okay";
> +
> + mdio {
> + phy0: phy at 1 {
> + compatible = "ethernet-phy-ieee802.3-c22";
> + reg = <1>;
> + reset-gpios = <&gpio 0 15 GPIO_ACTIVE_LOW>;
> + reset-assert-us = <10000>;
> + reset-deassert-us = <10000>;
> + };
> + };
> +};
> +
> &uart0 {
> status = "okay";
> };
> diff --git a/arch/riscv/boot/dts/spacemit/k3-pinctrl.dtsi b/arch/riscv/boot/dts/spacemit/k3-pinctrl.dtsi
> new file mode 100644
> index 000000000000..e02254961764
> --- /dev/null
> +++ b/arch/riscv/boot/dts/spacemit/k3-pinctrl.dtsi
> @@ -0,0 +1,44 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +/*
> + * Copyright (c) 2026 SpacemiT (Hangzhou) Technology Co. Ltd
> + */
> +
> +#include <dt-bindings/gpio/gpio.h>
> +
> +#define K3_PADCONF(pin, func) (((pin) << 16) | (func))
> +
> +&pinctrl {
> + gmac0_rgmii_0_cfg: gmac0-rgmii-0-cfg {
..
> + gmac-rgmii-0-pins {
for consistency, here should name it as gmac0-rgmii-0-pins, to show
explicitly these pins from gmac0 controller
> + pinmux = <K3_PADCONF(0, 1)>, /* gmac0_rxdv */
> + <K3_PADCONF(1, 1)>, /* gmac0_rx_d0 */
> + <K3_PADCONF(2, 1)>, /* gmac0_rx_d1 */
> + <K3_PADCONF(3, 1)>, /* gmac0_rx_clk */
> + <K3_PADCONF(4, 1)>, /* gmac0_rx_d2 */
> + <K3_PADCONF(5, 1)>, /* gmac0_rx_d3 */
> + <K3_PADCONF(6, 1)>, /* gmac0_tx_d0 */
> + <K3_PADCONF(7, 1)>, /* gmac0_tx_d1 */
> + <K3_PADCONF(8, 1)>, /* gmac0_tx_clk */
> + <K3_PADCONF(9, 1)>, /* gmac0_tx_d2 */
> + <K3_PADCONF(10, 1)>, /* gmac0_tx_d3 */
> + <K3_PADCONF(11, 1)>, /* gmac0_tx_en */
> + <K3_PADCONF(12, 1)>, /* gmac0_mdc */
> + <K3_PADCONF(13, 1)>; /* gmac0_mdio */
> +
> + bias-disable;
> + drive-strength = <25>;
> + power-source = <1800>;
> + };
> +
> + };
> +
> + gmac0_phy_0_cfg: gmac0-phy-0-cfg {
> + gmac0-3-pins {
or gmac0-int-pins? I'm not sure if better to embed the number here?
(whether you want to change it here, please keep consistency with
previous one)
> + pinmux = <K3_PADCONF(14, 1)>; /* gmac0_int */
> +
> + bias-disable;
> + drive-strength = <25>;
> + power-source = <1800>;
> + };
> + };
> +};
> diff --git a/arch/riscv/boot/dts/spacemit/k3.dtsi b/arch/riscv/boot/dts/spacemit/k3.dtsi
> index 6cc31e94c13a..4c0cc135dc09 100644
> --- a/arch/riscv/boot/dts/spacemit/k3.dtsi
> +++ b/arch/riscv/boot/dts/spacemit/k3.dtsi
> @@ -5,6 +5,7 @@
> */
>
> #include <dt-bindings/clock/spacemit,k3-clocks.h>
> +#include <dt-bindings/reset/spacemit,k3-resets.h>
> #include <dt-bindings/interrupt-controller/irq.h>
>
> /dts-v1/;
> @@ -437,6 +438,109 @@ soc: soc {
> dma-noncoherent;
> ranges;
>
> + gmac_axi_setup: stmmac-axi-config {
> + snps,wr_osr_lmt = <0xf>;
> + snps,rd_osr_lmt = <0xf>;
> + /* max axi burst len is 256 */
> + snps,blen = <256 128 64 32 16 0 0>;
> + };
> +
> + eth0: ethernet at cac80000 {
> + compatible = "spacemit,k3-dwmac", "snps,dwmac-5.40a";
> + reg = <0x0 0xcac80000 0x0 0x2000>;
> + clocks = <&syscon_apmu CLK_APMU_EMAC0_BUS>,
> + <&syscon_apmu CLK_APMU_EMAC0_1588>,
> + <&syscon_apmu CLK_APMU_EMAC0_RGMII_TX>;
> + clock-names = "stmmaceth", "ptp_ref", "tx";
> + interrupts = <131 IRQ_TYPE_LEVEL_HIGH>,
> + <276 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "macirq", "eth_wake_irq";
> + resets = <&syscon_apmu RESET_APMU_EMAC0>;
> + reset-names = "stmmaceth";
> + rx-fifo-depth = <8192>;
> + tx-fifo-depth = <8192>;
> + snps,multicast-filter-bins = <64>;
> + snps,perfect-filter-entries = <32>;
> + snps,aal;
> + snps,tso;
> + snps,txpbl = <8>;
> + snps,rxpbl = <8>;
> + snps,force_sf_dma_mode;
> + snps,axi-config = <&gmac_axi_setup>;
> + spacemit,apmu = <&syscon_apmu 0x3e4 0x3e8>;
> + status = "disabled";
> +
> + mdio {
> + compatible = "snps,dwmac-mdio";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + };
> + };
> +
> + eth1: ethernet at cac82000 {
> + compatible = "spacemit,k3-dwmac", "snps,dwmac-5.40a";
> + reg = <0x0 0xcac82000 0x0 0x2000>;
> + clocks = <&syscon_apmu CLK_APMU_EMAC1_BUS>,
> + <&syscon_apmu CLK_APMU_EMAC1_1588>,
> + <&syscon_apmu CLK_APMU_EMAC1_RGMII_TX>;
> + clock-names = "stmmaceth", "ptp_ref", "tx";
> + interrupts = <133 IRQ_TYPE_LEVEL_HIGH>,
> + <277 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "macirq", "eth_wake_irq";
> + resets = <&syscon_apmu RESET_APMU_EMAC1>;
> + reset-names = "stmmaceth";
> + rx-fifo-depth = <8192>;
> + tx-fifo-depth = <8192>;
> + snps,multicast-filter-bins = <64>;
> + snps,perfect-filter-entries = <32>;
> + snps,aal;
> + snps,tso;
> + snps,txpbl = <8>;
> + snps,rxpbl = <8>;
> + snps,force_sf_dma_mode;
> + snps,axi-config = <&gmac_axi_setup>;
> + spacemit,apmu = <&syscon_apmu 0x3ec 0x3f0>;
> + status = "disabled";
> +
> + mdio {
> + compatible = "snps,dwmac-mdio";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + };
> + };
> +
> + eth2: ethernet at cac8e000 {
> + compatible = "spacemit,k3-dwmac", "snps,dwmac-5.40a";
> + reg = <0x0 0xcac8e000 0x0 0x2000>;
> + clocks = <&syscon_apmu CLK_APMU_EMAC2_BUS>,
> + <&syscon_apmu CLK_APMU_EMAC2_1588>,
> + <&syscon_apmu CLK_APMU_EMAC2_RGMII_TX>;
> + clock-names = "stmmaceth", "ptp_ref", "tx";
> + interrupts = <130 IRQ_TYPE_LEVEL_HIGH>,
> + <278 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "macirq", "eth_wake_irq";
> + resets = <&syscon_apmu RESET_APMU_EMAC2>;
> + reset-names = "stmmaceth";
> + rx-fifo-depth = <4096>;
> + tx-fifo-depth = <4096>;
> + snps,multicast-filter-bins = <64>;
> + snps,perfect-filter-entries = <32>;
> + snps,aal;
> + snps,tso;
> + snps,txpbl = <8>;
> + snps,rxpbl = <8>;
> + snps,force_sf_dma_mode;
> + snps,axi-config = <&gmac_axi_setup>;
> + spacemit,apmu = <&syscon_apmu 0x248 0x24c>;
> + status = "disabled";
> +
> + mdio {
> + compatible = "snps,dwmac-mdio";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + };
> + };
> +
> syscon_apbc: system-controller at d4015000 {
> compatible = "spacemit,k3-syscon-apbc";
> reg = <0x0 0xd4015000 0x0 0x1000>;
> --
> 2.53.0
>
>
--
Yixun Lan (dlan)
More information about the linux-riscv
mailing list