[PATCH 1/1] usb: dwc3: dwc3-generic-plat: Add optional VBUS regulator support
Thinh Nguyen
Thinh.Nguyen at synopsys.com
Wed Mar 18 16:15:44 PDT 2026
On Wed, Mar 18, 2026, Chukun Pan wrote:
> Hi,
>
> > If we have a specific user, please include it in the change log. In this
> > case, it looks like spacemit k1 as noted under the "---" line?
>
> I will change it to "Some SpacemiT K1 board".
>
> > The name "vbus" here maybe confusing. This regulator powers the
> > controller chip and not neccessarily turning on VBUS of the USB bus
> > power line. Is there a common/different name for regulator id?
> > At least fix the error message.
>
> Sorry, but I don't quite understand what you mean.
> Taking the OrangePi RV2 [1] board as an example:
>
> VCC_5V0 (IN) -> VCC5V0_USB3 (OUT) -> Vbus30
>
> The VCC5V0_USB3 regulator is connected to the USB vbus pin.
> I think it's okay to call it "vbus" here?
>
I mean this is a generic glue driver and not specific to your spacemit
k1. Some platforms use regulators to drive the vbus (e.g. dwc3 meson)
while others for internal controller supplies (e.g. dwc3 exynos). Also,
if the platform is operating in device mode, there should be no vbus.
Also do we want to disable the regulator on system suspend? If so, we
may need a regulator handle.
Perhaps can we pass the regulator id string through the
dwc3_generic_config? Create a new field to store this ID.
Something like this?
struct dwc3_generic_config {
int (*init)(struct dwc3_generic *dwc3g);
struct {
const char *id;
bool disable_on_suspend;
} regulator;
struct dwc3_properties properties;
};
BR,
Thinh
More information about the linux-riscv
mailing list