[PATCH] irqchip/riscv-rpmi-sysmsi: Fix mailbox channel leak in rpmi_sysmsi_probe()
Rahul Pathak
rahul at summations.net
Sun Mar 15 10:24:08 PDT 2026
On Sun, Mar 15, 2026 at 12:48 PM Felix Gu <ustc.gu at gmail.com> wrote:
>
> When riscv_acpi_get_gsi_info() fails, the mailbox channel previously
> requested via mbox_request_channel() is not freed. Add the missing
> mbox_free_channel() call to prevent the resource leak.
>
> Fixes: 4752b0cfbc37 ("irqchip/riscv-rpmi-sysmsi: Add ACPI support")
> Signed-off-by: Felix Gu <ustc.gu at gmail.com>
> ---
> drivers/irqchip/irq-riscv-rpmi-sysmsi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/irqchip/irq-riscv-rpmi-sysmsi.c b/drivers/irqchip/irq-riscv-rpmi-sysmsi.c
> index 5c74c561ce31..612f3972f7af 100644
> --- a/drivers/irqchip/irq-riscv-rpmi-sysmsi.c
> +++ b/drivers/irqchip/irq-riscv-rpmi-sysmsi.c
> @@ -250,6 +250,7 @@ static int rpmi_sysmsi_probe(struct platform_device *pdev)
> rc = riscv_acpi_get_gsi_info(fwnode, &priv->gsi_base, &id,
> &nr_irqs, NULL);
> if (rc) {
> + mbox_free_channel(priv->chan);
> dev_err(dev, "failed to find GSI mapping\n");
> return rc;
> }
>
Reviewed-by: Rahul Pathak <rahul at summations.net>
More information about the linux-riscv
mailing list