[PATCH 3/3] phy: k1-usb: k3: add USB2 PHY support
Yixun Lan
dlan at gentoo.org
Thu Feb 12 06:35:30 PST 2026
Hi Yao,
On 11:30 Thu 12 Feb , Yao Zi wrote:
> On Thu, Feb 12, 2026 at 09:38:56AM +0800, Yixun Lan wrote:
> > Add USB2 PHY support for SpacemiT K3 SoC.
> >
> > Register layout of handling USB disconnect operation has been changed,
> > So introducing a platform data to distinguish the different SoCs.
>
> Would it be clearer and simpler if you define separate phy_ops for
> k1 and k3, and point of_device_id.data directly to the corresponding
> phy_ops? Then there's no need to introduce either spacemit_usb2phy_data
> structure, or spacemit_usb2phy_disconnect wrapper.
>
Yes, I agree, thanks for the suggestion
--
Yixun Lan (dlan)
More information about the linux-riscv
mailing list