[PATCH 1/2] dt-bindings: phy: spacemit: add regulator support to K1 USB2 PHY
Ze Huang
huang.ze at linux.dev
Mon Feb 9 21:50:32 PST 2026
On Mon Feb 9, 2026 at 2:40 PM CST, Chukun Pan wrote:
> Hi,
>
>> Plus, if this was a vbus regulator it would not be called "phy"...
>> Even more confusing.
>
> Sorry, I didn't consider that this naming is confusing. Other
> platforms, such as Rockchip's inno-usb2phy driver, use the
> "phy-supply" property. I continued with this bad naming.
>
>> Bindings are supposed to be complete regardless what driver does
>> (or does not).
>>
>> You must list all supplies with proper names.
>>
>> If this regulator was missing, then what else?
>
> (...)
>
>> Please start describing in the bindings your complete hardware, not
>> your drivers.
>
> It appears Ze Huang described the vbus-supply property in
> spacemit.k1-dwc3.yaml.
>
> So I should enable the regulator in the dwc3-generic-plat driver.
No, we will enable regulator at port level.
>
> Sorry for the noise.
>
> Thanks,
> Chukun
More information about the linux-riscv
mailing list