[PATCH v3 1/3] dt-bindings: mfd: spacemit,p1: Add individual regulator supply properties

Guodong Xu guodong at riscstar.com
Wed Feb 4 23:42:01 PST 2026


On Thu, Feb 5, 2026 at 2:07 AM Conor Dooley <conor at kernel.org> wrote:
>
> On Wed, Feb 04, 2026 at 09:23:01PM +0800, Guodong Xu wrote:
> > Add supply properties that match the P1 PMIC's actual hardware topology
> > where each buck converter has its own VIN pin and LDO groups share
> > common input pins. Supply names are defined according to the pinout
> > names in the P1 datasheet.
> >
> > The existing "vin-supply" is marked as deprecated to avoid warnings
> > as dts and dt-bindings go via different trees.
> >
> > Signed-off-by: Guodong Xu <guodong at riscstar.com>
> > ---
> > v3: Mark vin-supply as deprecated.
> > v2: Remove providers from the dts example.
> >     Pass the 'make dt_binding_check' test.
> > ---
> >  .../devicetree/bindings/mfd/spacemit,p1.yaml       | 53 +++++++++++++++++++++-
> >  1 file changed, 52 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/mfd/spacemit,p1.yaml b/Documentation/devicetree/bindings/mfd/spacemit,p1.yaml
> > index c6593ac6ef6a..41f784408e29 100644
> > --- a/Documentation/devicetree/bindings/mfd/spacemit,p1.yaml
> > +++ b/Documentation/devicetree/bindings/mfd/spacemit,p1.yaml
> > @@ -28,7 +28,46 @@ properties:
> >      maxItems: 1
> >
> >    vin-supply:
> > -    description: Input supply phandle.
> > +    deprecated: true
> > +    description:
> > +      Main power input (deprecated). Use individual vin1-6, aldoin,
> > +      dldoin1, and dldoin2 supply properties instead.
>
> What's the point documenting the deprecated version if it doesn't work
> anymore?

Keeping "vin-supply" in the binding with "deprecated: true" avoids a cross-tree
warning. Since dts and dt-bindings go via different trees, the new binding +
old dts triggers:

pmic at 41 (spacemit,p1): Unevaluated properties are not allowed
('vin-supply' was unexpected)

Rob flagged this in [1] as 'intermittent warnings'.

I'm open to dropping the deprecated markup, maybe just accepting the
transient warning is fine?

Link: https://lore.kernel.org/all/20260129181604.GA1398997-robh@kernel.org/ [1]

Best regards,
Guodong Xu



More information about the linux-riscv mailing list