[PATCH v8 2/3] clk: canaan: Add clock driver for Canaan K230
Yao Zi
ziyao at disroot.org
Sat Sep 6 20:17:26 PDT 2025
On Sun, Sep 07, 2025 at 03:13:07AM +0000, Yao Zi wrote:
> > +struct k230_clk_rate_self {
> > + struct clk_hw hw;
> > + void __iomem *reg;
> > + bool read_only;
>
> Isn't a read-only multiplier, divider or something capable of both a
> simple fixed-factor hardware? If so please switch to the existing clock
> hardware, instead of introducing a field in description of rate clocks.
>
> It's worth noting that you've already had at least one fixed-rate clock
> (shrm_sram_div2).
It should be "fixed-factor" clock instead of "fixed-rate" clock, sorry
for the typo.
Regards,
Yao Zi
More information about the linux-riscv
mailing list