[PATCH net] net: spacemit: Remove broken flow control support

Andrew Lunn andrew at lunn.ch
Fri Oct 31 09:27:31 PDT 2025


On Fri, Oct 31, 2025 at 04:21:53PM +0800, Vivian Wang wrote:
> Currently, emac_set_pauseparam() will oops if userspace calls it while
> the interface is not up. The reason is that if the interface is not up,
> phydev may be NULL, but is still accessed in emac_set_fc() and
> emac_set_fc_autoneg().
> 
> Since the existing flow control implementation is somewhat broken in
> general (for example, it doesn't handle autonegotiation properly),
> remove it for now to fix the more urgent oops problem. A better
> implementation will be sent in future patches.

Fixes for net/stable should be minimal. Please fix the opps, by
returning -ENETDOWN and leave the broken implementation in place. You
can then fix it up in net-next, were we allow more invasive changes.

    Andrew

---
pw-bot: cr



More information about the linux-riscv mailing list