[PATCH v4 2/2] ASoC: spacemit: add i2s support for K1 SoC

Troy Mitchell troy.mitchell at linux.spacemit.com
Mon Oct 13 18:14:57 PDT 2025


On Mon, Oct 13, 2025 at 01:05:58PM +0100, Mark Brown wrote:
> On Sun, Sep 21, 2025 at 04:52:17PM +0800, Troy Mitchell wrote:
> 
> > +	case SND_SOC_DAIFMT_DSP_A:
> > +	case SND_SOC_DAIFMT_DSP_B:
> > +		snd_pcm_hw_constraint_minmax(substream->runtime,
> > +					     SNDRV_PCM_HW_PARAM_CHANNELS,
> > +					     1, 1);
> > +		snd_pcm_hw_constraint_mask64(substream->runtime,
> > +					     SNDRV_PCM_HW_PARAM_FORMAT,
> > +					     SNDRV_PCM_FMTBIT_S32_LE);
> > +		break;
> 
> The handling for one of these is buggy, DSP A and B are distinct modes
> but throughout the driver they're handled identically AFAICT.
Thanks! Indeed, this bug was introduced in this version.
I’ll fix it and send v5 ASAP.

                            - Troy





More information about the linux-riscv mailing list