[PATCH/RFC 1/2] of/irq: Ignore interrupt parent for nodes without interrupts
Rob Herring
robh at kernel.org
Fri Oct 3 06:32:57 PDT 2025
On Fri, Oct 3, 2025 at 5:08 AM Geert Uytterhoeven
<geert+renesas at glider.be> wrote:
>
> The Devicetree Specification states:
>
> The root of the interrupt tree is determined when traversal of the
> interrupt tree reaches an interrupt controller node without an
> interrupts property and thus no explicit interrupt parent.
>
> However, of_irq_init() gratuitously assumes that a node without
> interrupts has an actual interrupt parent if it finds an
> interrupt-parent property higher up in the device tree. Hence when such
> a property is present (e.g. in the root node), the root interrupt
> controller may not be detected as such, causing a panic:
>
> OF: of_irq_init: children remain, but no parents
> Kernel panic - not syncing: No interrupt controller found.
>
> Commit e91033621d56e055 ("of/irq: Use interrupts-extended to find
> parent") already fixed a first part, by checking for the presence of an
> interrupts-extended property. Fix the second part by only calling
> of_irq_find_parent() when an interrupts property is present.
Seems reasonable. Why the RFC tag?
Normally I'd worry about some ancient PPC or Sparc system, but they
don't use of_irq_init().
Rob
More information about the linux-riscv
mailing list