[PATCH v11 1/3] pwm: Export `pwmchip_release` for external use

[Uwe Kleine-König]

Hello Michal,

On Thu, Jul 10, 2025 at 08:54:28PM +0200, Michal Wilczynski wrote:
> diff --git a/include/linux/pwm.h b/include/linux/pwm.h
> index 8cafc483db53addf95591d1ac74287532c0fa0ee..8f0698c09e62b893d63fc258da3c34781183056f 100644
> --- a/include/linux/pwm.h
> +++ b/include/linux/pwm.h
> @@ -478,6 +478,7 @@ static inline bool pwm_might_sleep(struct pwm_device *pwm)
>  
>  /* PWM provider APIs */
>  void pwmchip_put(struct pwm_chip *chip);
> +void pwmchip_release(struct device *dev);

I want this in a separate section because "normal" provider don't need
that. Please add a comment that this is only public for technical
reasons for the Rust wrappers.

I understand you are eager to get this merged, but still I'd ask you to
slow down your patch sending frequency. Currently I tend to not apply it
for v6.17-rc1 as I'd like to have that in next for some time.

With you waiting a bit longer before v11 I would have written that in
reply to the explanation in the v10 thread and we might have saved
one iteration ...

>  struct pwm_chip *pwmchip_alloc(struct device *parent, unsigned int npwm, size_t sizeof_priv);
>  struct pwm_chip *devm_pwmchip_alloc(struct device *parent, unsigned int npwm, size_t sizeof_priv);
>  
> @@ -551,6 +552,10 @@ static inline void pwmchip_put(struct pwm_chip *chip)
>  {
>  }
>  
> +static inline void pwmchip_release(struct device *dev)
> +{
> +}
> +

Is this needed? There is no user of this function that doesn't depend
on CONFIG_PWM?!

>  static inline struct pwm_chip *pwmchip_alloc(struct device *parent,
>  					     unsigned int npwm,
>  					     size_t sizeof_priv)
> 

Best regards
Uwe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-riscv/attachments/20250710/20b77eac/attachment.sig>