[PATCH] riscv: Stop considering R_RISCV_NONE as bad relocations
Palmer Dabbelt
palmer at dabbelt.com
Thu Jul 10 11:43:00 PDT 2025
On Thu, 10 Jul 2025 01:34:31 PDT (-0700), alexghiti at rivosinc.com wrote:
> Even though those relocations should not be present in the final
> vmlinux, there are a lot of them. And since those relocations are
> considered "bad", they flood the compilation output which may hide some
> legitimate bad relocations.
>
> Signed-off-by: Alexandre Ghiti <alexghiti at rivosinc.com>
> ---
> arch/riscv/tools/relocs_check.sh | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/riscv/tools/relocs_check.sh b/arch/riscv/tools/relocs_check.sh
> index baeb2e7b2290558d696afbc5429d6a3c69ae49e1..742993e6a8cba72c657dd2f8f5dabc4c415e84bd 100755
> --- a/arch/riscv/tools/relocs_check.sh
> +++ b/arch/riscv/tools/relocs_check.sh
> @@ -14,7 +14,9 @@ bad_relocs=$(
> ${srctree}/scripts/relocs_check.sh "$@" |
> # These relocations are okay
> # R_RISCV_RELATIVE
> - grep -F -w -v 'R_RISCV_RELATIVE'
> + # R_RISCV_NONE
> + grep -F -w -v 'R_RISCV_RELATIVE
> +R_RISCV_NONE'
> )
I'm not super opposed to it, but is there a way to just warn once or
something? It's probably best to still report something, as there's
likely some sort of toolchain issue here.
Also: if you can reproduce it, Nelson can probably fix it. I'm CCing
him.
>
> if [ -z "$bad_relocs" ]; then
More information about the linux-riscv
mailing list