[PATCH] riscv: mmap(): use unsigned offset type in riscv_sys_mmap

Han Gao (Revy) rabenda.cn at gmail.com
Tue Jul 8 22:28:18 PDT 2025



> On Jul 7, 2025, at 19:34, liu.xuemei1 at zte.com.cn wrote:
> 
> From: Jessica Liu <liu.xuemei1 at zte.com.cn>
> 
> The variable type of offset should be consistent with the relevant
> interfaces of mmap which described in commit 295f10061af0 ("syscalls:
> mmap(): use unsigned offset type consistently). Otherwise, a user input
> with the top bit set would result in a negative page offset rather than a
> large one.
> 
> Signed-off-by: Jessica Liu <liu.xuemei1 at zte.com.cn>
Tested-by: Han Gao <rabenda.cn at gmail.com>
> ---
> arch/riscv/kernel/sys_riscv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/riscv/kernel/sys_riscv.c b/arch/riscv/kernel/sys_riscv.c
> index d77afe05578f..795b2e815ac9 100644
> --- a/arch/riscv/kernel/sys_riscv.c
> +++ b/arch/riscv/kernel/sys_riscv.c
> @@ -10,7 +10,7 @@
> 
> static long riscv_sys_mmap(unsigned long addr, unsigned long len,
> 			   unsigned long prot, unsigned long flags,
> -			   unsigned long fd, off_t offset,
> +			   unsigned long fd, unsigned long offset,
> 			   unsigned long page_shift_offset)
> {
> 	if (unlikely(offset & (~PAGE_MASK >> page_shift_offset)))
> -- 
> 2.25.1
> 
> _______________________________________________
> linux-riscv mailing list
> linux-riscv at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
> 




More information about the linux-riscv mailing list