[PATCH] riscv: ftrace: Fix the logic issue in DYNAMIC_FTRACE selection

[Alexandre Ghiti]

Hi Chen Miao,

On 7/4/25 04:06, Miao Chen wrote:
> Hello Alex,
>
> Should I wait for Steven to finish his work before starting mine? He 
> seems to be refactoring a lot of CONFIG logic, which might cause 
> conflicts.


I would say no, don't wait for Steven since his work won't land in 6.16, 
we need a fix to prevent build failures for this release.

Thanks,

Alex


>
> Thanks,
>
> Chen Miao
>
> Alexandre Ghiti <alex at ghiti.fr> 于2025年7月4日周五 00:06写道：
>
>     Hi Steve,
>
>     On 7/3/25 17:40, Steven Rostedt wrote:
>     > On Thu, 3 Jul 2025 15:00:02 +0200
>     > Alexandre Ghiti <alex at ghiti.fr> wrote:
>     >
>     >
>     >> We could support static ftrace, but I don't think we should, so
>     I agree
>     >> with this patch. In fact I had just prepared a patch for this here
>     >>
>     https://github.com/linux-riscv/linux/pull/556/commits/0481092a5bec3818658981c11f629e06e66382b3
>     >> which is a bit more complete since I have removed some dead code.
>     >>
>     >> Let's see what other people think about supporting static
>     ftrace, I have
>     >> added Steven in cc if he has an opinion.
>     > Yes, please only support the dynamic ftrace. The static is there
>     only
>     > to help archs to get ftrace up and running. Once dynamic is
>     supported,
>     > static should not be used.
>     >
>     > Hmm, maybe I should just remove the prompt for DYNAMIC_FTRACE.
>     >
>     > That is, once it is supported by an architecture, it should be
>     the only
>     > thing used.
>     >
>     > -- Steve
>
>
>     Thanks for your input.
>
>     @ChenMiao: can you come up with a v2 that, in addition, deletes
>     the dead
>     code and with a commit log that explains what Steven said? If not
>     possible for you, let me know and I'll do it.
>
>     Thanks,
>
>     Alex
>