[PATCH v6 06/23] mailbox: Add RISC-V SBI message proxy (MPXY) based mailbox driver

[Anup Patel]

On Mon, Jun 23, 2025 at 2:20 PM Andy Shevchenko
<andriy.shevchenko at linux.intel.com> wrote:
>
> On Wed, Jun 18, 2025 at 05:43:41PM +0530, Anup Patel wrote:
> > Add a mailbox controller driver for the new SBI message proxy extension
> > which is part of the SBI v3.0 specification.
>
> ...
>
> > +static void mpxy_mbox_remove(struct platform_device *pdev)
> > +{
> > +     struct mpxy_mbox *mbox = platform_get_drvdata(pdev);
>
> > +     if (mbox->msi_count)
>
> I'm still not convinced we need this check _here_.
> Can it be rather a separate patch to add it inside
> the below call?

IMHO, improving platform_device_msi_free_irqs_all() and its
users should be a separate series.

>
> > +             platform_device_msi_free_irqs_all(mbox->dev);
> > +}
>
> ...
>
> > +static const struct of_device_id mpxy_mbox_of_match[] = {
> > +     {.compatible = "riscv,sbi-mpxy-mbox", },
>
> Missing space and unneeded inner comma.

Okay, I will update.

>
> > +     {}
> > +};
>
> ...
>
> > --- a/include/linux/byteorder/generic.h
> > +++ b/include/linux/byteorder/generic.h
>
> This is good change, but deserves to be in a separate patch.
> I will Ack/Review it as soon as it appears to be so.
>

I generally prefer introduction and usage of a new API in the
same patch since it provides better context. I don't mind creating
separate patch so I will update in the next revision.

Regards,
Anup