[PATCH v2] gpio: sifive: remove unneeded call to platform_set_drvdata()

Samuel Holland samuel.holland at sifive.com
Sun Nov 12 18:34:32 PST 2023


From: Andrei Coardos <aboutphysycs at gmail.com>

This function call was found to be unnecessary as there is no equivalent
platform_get_drvdata() call to access the private data of the driver. Also,
the private data is defined in this driver, so there is no risk of it being
accessed outside of this driver file.

Reviewed-by: Alexandru Ardelean <alex at shruggie.ro>
Signed-off-by: Andrei Coardos <aboutphysycs at gmail.com>
Reviewed-by: Andy Shevchenko <andy at kernel.org>
Signed-off-by: Samuel Holland <samuel.holland at sifive.com>
---

Changes in v2:
 - Rebase on v6.7-rc1

 drivers/gpio/gpio-sifive.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpio/gpio-sifive.c b/drivers/gpio/gpio-sifive.c
index 8decd9b5d229..067c8edb62e2 100644
--- a/drivers/gpio/gpio-sifive.c
+++ b/drivers/gpio/gpio-sifive.c
@@ -250,7 +250,6 @@ static int sifive_gpio_probe(struct platform_device *pdev)
 	girq->handler = handle_bad_irq;
 	girq->default_type = IRQ_TYPE_NONE;
 
-	platform_set_drvdata(pdev, chip);
 	return gpiochip_add_data(&chip->gc, chip);
 }
 
-- 
2.42.0




More information about the linux-riscv mailing list