[PATCH 0/3] riscv: sbi: Switch to the sys-off handler API
Palmer Dabbelt
palmer at dabbelt.com
Fri May 12 14:51:37 PDT 2023
On Fri, 12 May 2023 14:50:17 PDT (-0700), Palmer Dabbelt wrote:
> On Wed, 28 Dec 2022 10:30:11 PST (-0800), Conor Dooley wrote:
>> Hey Samuel,
>>
>> On Wed, Dec 28, 2022 at 10:19:12AM -0600, Samuel Holland wrote:
>>> I want to convert the axp20x PMIC poweroff handler to use the sys-off
>>> API, so it can be used as a fallback for if the SBI poweroff handler
>>> is unavailable. But the SBI poweroff handler still uses pm_power_off, so
>>> done alone, this would cause the axp20x callback to be called first,
>>> before the SBI poweroff handler has a chance to run.
>>>
>>> In order to prevent this change in behavior, the SBI poweroff handler
>>> needs to be converted to the sys-off API first, at a higher priority.
>>>
>>> This series performs the conversion, after accounting for the fact that
>>> the SBI poweroff handler is registered quite early during boot.
>>>
>>> The first patch is a dependency for both this series and the PSCI
>>> series[1], so I would like to get at least patch 1 merged soon.
>>>
>>> [1]: https://lore.kernel.org/lkml/20221105214841.7828-1-samuel@sholland.org/
>>>
>>>
>>> Samuel Holland (3):
>>> kernel/reboot: Use the static sys-off handler for any priority
>>> riscv: sbi: Share the code for unsupported extension warnings
>>> riscv: sbi: Switch to the sys-off handler API
>>
>> Not what other stuff has reboot support, so I gave it a whirl on
>> PolarFire SoC & it seemed to work as expected:
>> Tested-by: Conor Dooley <conor.dooley at microchip.com>
>
> Acked-by: Palmer Dabbelt <palmer at rivosinc.com>
>
> in case the reboot folks want to take these. I'm also happy to take the
> reboot change through the RISC-V tree with an Ack. There's some
> discussion about this in the previous patches.
sorry, this is the old version -- I just got lost...
>
>>
>> Thanks,
>> Conor.
More information about the linux-riscv
mailing list