[PATCH v4 6/7] riscv: dts: starfive: jh7110: Add syscon nodes

Krzysztof Kozlowski krzysztof.kozlowski at linaro.org
Thu May 11 23:36:39 PDT 2023


On 12/05/2023 04:20, Xingyu Wu wrote:
> From: William Qiu <william.qiu at starfivetech.com>
> 
> Add stg_syscon/sys_syscon/aon_syscon nodes for JH7110 Soc.
> 
> Co-developed-by: Xingyu Wu <xingyu.wu at starfivetech.com>
> Signed-off-by: Xingyu Wu <xingyu.wu at starfivetech.com>
> Reviewed-by: Conor Dooley <conor.dooley at microchip.com>
> Reviewed-by: Emil Renner Berthing <emil.renner.berthing at canonical.com>
> Signed-off-by: William Qiu <william.qiu at starfivetech.com>
> ---
>  arch/riscv/boot/dts/starfive/jh7110.dtsi | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/arch/riscv/boot/dts/starfive/jh7110.dtsi b/arch/riscv/boot/dts/starfive/jh7110.dtsi
> index 4c5fdb905da8..fa27fd4169a8 100644
> --- a/arch/riscv/boot/dts/starfive/jh7110.dtsi
> +++ b/arch/riscv/boot/dts/starfive/jh7110.dtsi
> @@ -353,6 +353,11 @@ i2c2: i2c at 10050000 {
>  			status = "disabled";
>  		};
>  
> +		stg_syscon: syscon at 10240000 {
> +			compatible = "starfive,jh7110-stg-syscon", "syscon";
> +			reg = <0x0 0x10240000 0x0 0x1000>;
> +		};
> +
>  		uart3: serial at 12000000 {
>  			compatible = "snps,dw-apb-uart";
>  			reg = <0x0 0x12000000 0x0 0x10000>;
> @@ -457,6 +462,11 @@ syscrg: clock-controller at 13020000 {
>  			#reset-cells = <1>;
>  		};
>  
> +		sys_syscon: syscon at 13030000 {
> +			compatible = "starfive,jh7110-sys-syscon", "syscon", "simple-mfd";
> +			reg = <0x0 0x13030000 0x0 0x1000>;

No children, drop the simple-mfd. Or your binding is incorrect or your
DTS is incomplete (you mentioned clock-controller). DTS should be complete.

Best regards,
Krzysztof




More information about the linux-riscv mailing list