[PATCH v2 3/4] gpio: sifive: Get the parent IRQ's domain from its irq_data
Andy Shevchenko
andy at kernel.org
Wed Jul 19 09:54:22 PDT 2023
On Wed, Jul 19, 2023 at 09:34:44AM -0700, Samuel Holland wrote:
> Do not parse the devicetree again when the data is already available
> from the IRQ subsystem. This follows the example of the ThunderX and
> X-Gene GPIO drivers. The ngpio check is needed to avoid a possible
> out-of-bounds read.
...
> - girq->parent_domain = parent;
> + girq->parent_domain = irq_get_irq_data(chip->irq_number[0])->domain;
For the sake of readability I would like to leave parent variable
and assign it beforehand somewhere upper in the code.
Also, can irq_get_irq_data() return NULL? Needs a comment on top
of that assignment or an additional check.
--
With Best Regards,
Andy Shevchenko
More information about the linux-riscv
mailing list