[PATCH v3] riscv: entry: set a0 = -ENOSYS only when syscall != -1
Björn Töpel
bjorn at kernel.org
Wed Jul 19 09:28:47 PDT 2023
Andreas Schwab <schwab at suse.de> writes:
> On Jul 19 2023, Celeste Liu wrote:
>
>> @@ -308,7 +312,7 @@ asmlinkage __visible __trap_section void do_trap_ecall_u(struct pt_regs *regs)
>>
>> if (syscall < NR_syscalls)
>> syscall_handler(regs, syscall);
>> - else
>> + else if ((long)syscall != -1L)
>
> You can also use syscall != -1UL or even syscall != -1.
The former is indeed better for the eyes! :-) The latter will get a
-Wsign-compare warning, no?
Björn
More information about the linux-riscv
mailing list