[PATCH v2 04/15] spi: Replace open coded spi_controller_xfer_timeout()
Mark Brown
broonie at kernel.org
Tue Jul 11 06:05:18 PDT 2023
On Tue, Jul 11, 2023 at 10:28:13AM +0200, AngeloGioacchino Del Regno wrote:
> Il 10/07/23 17:49, Andy Shevchenko ha scritto:
> > + ms = spi_controller_xfer_timeout(ctlr, xfer);
> I agree on using helpers, but the logic is slightly changing here: yes it is
> unlikely (and also probably useless) to get ms == UINT_MAX, but the helper is
> limiting the maximum timeout value to 500mS, which may not work for some slow
> controllers/devices.
The helper is limiting the *minimum* timeout value to 500ms - it's using
max() not min(). The idea is the other way around, that for a very fast
transfer we don't want to end up with such a short timeout that it false
triggers due to scheduling issues.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-riscv/attachments/20230711/dcbc3f4e/attachment.sig>
More information about the linux-riscv
mailing list