[PATCH v6 00/15] tools/nolibc: add a new syscall helper

Zhangjin Wu falcon at tinylab.org
Fri Jul 7 07:49:28 PDT 2023


Hi, Willy

Here is the v6 of the __sysret series [1], applies your suggestions.
additionally, the sbrk() also uses the __sysret helper.

These patches are tested (together with the coming v4 selftests/nolibc
patches) for all of the supported architectures:

           arch/board | result
          ------------|------------
      arm/vexpress-a9 | 142 test(s) passed, 1 skipped, 0 failed.
             arm/virt | 142 test(s) passed, 1 skipped, 0 failed.
         aarch64/virt | 142 test(s) passed, 1 skipped, 0 failed.
          ppc/g3beige | not supported
          ppc/ppce500 | not supported
              i386/pc | 142 test(s) passed, 1 skipped, 0 failed.
            x86_64/pc | 142 test(s) passed, 1 skipped, 0 failed.
         mipsel/malta | 142 test(s) passed, 1 skipped, 0 failed.
     loongarch64/virt | 142 test(s) passed, 1 skipped, 0 failed.
         riscv64/virt | 142 test(s) passed, 1 skipped, 0 failed.
         riscv32/virt | 0 test(s) passed, 0 skipped, 0 failed.
s390x/s390-ccw-virtio | 142 test(s) passed, 1 skipped, 0 failed.

Changes from v5 --> v6:

* tools/nolibc: arch-*.h: fix up code indent errors
  toolc/nolibc: arch-*.h: clean up whitespaces after __asm__

    Fix up the code indent errors and whitespaces between __asm__ and volatile.

    The post-whitespaces are reserved as before.

* tools/nolibc: arch-loongarch.h: shrink with _NOLIBC_SYSCALL_CLOBBERLIST
  tools/nolibc: arch-mips.h: shrink with _NOLIBC_SYSCALL_CLOBBERLIST

    Add _NOLIBC_ prefix for SYSCALL_CLOBBERLIST.

* tools/nolibc: add missing my_syscall6() for mips

    Use post-whitespaces instead of post-tab.

    The above 4 patches are preparation for this one.

* tools/nolibc: __sysret: support syscalls who return a pointer

    Add comments about the new errno range [-MAX_ERRNOR, -1], add ref to
    the musl and glibc.

* tools/nolibc: clean up mmap() routine

    Comment the MAP_FAILED return info.

* tools/nolibc: clean up sbrk() routine

    New patch, applies __sysret() helper too and also fixes up an error
    reported by scripts/checkpatch.pl.

* selftests/nolibc: export argv0 for some tests
  selftests/nolibc: prepare: create /dev/zero

    Prepare /dev/zero and argv0 for mmap test cases.

* selftests/nolibc: add EXPECT_PTREQ, EXPECT_PTRNE and EXPECT_PTRER
  selftests/nolibc: add sbrk_0 to test current brk getting

    No change.

* selftests/nolibc: add mmap_bad test case
  selftests/nolibc: add munmap_bad test case
  selftests/nolibc: add mmap_munmap_good test case

    Split the first two out to standalone patches.

    Add /dev/zero and argv0 to the file list and assigns a file_size
    manually for /dev/zero.

Best regards,
Zhangjin
---
[1]: https://lore.kernel.org/lkml/cover.1687957589.git.falcon@tinylab.org/

Zhangjin Wu (15):
  tools/nolibc: arch-*.h: fix up code indent errors
  toolc/nolibc: arch-*.h: clean up whitespaces after __asm__
  tools/nolibc: arch-loongarch.h: shrink with _NOLIBC_SYSCALL_CLOBBERLIST
  tools/nolibc: arch-mips.h: shrink with _NOLIBC_SYSCALL_CLOBBERLIST
  tools/nolibc: add missing my_syscall6() for mips
  tools/nolibc: __sysret: support syscalls who return a pointer
  tools/nolibc: clean up mmap() routine
  tools/nolibc: clean up sbrk() routine
  selftests/nolibc: export argv0 for some tests
  selftests/nolibc: prepare: create /dev/zero
  selftests/nolibc: add EXPECT_PTREQ, EXPECT_PTRNE and EXPECT_PTRER
  selftests/nolibc: add sbrk_0 to test current brk getting
  selftests/nolibc: add mmap_bad test case
  selftests/nolibc: add munmap_bad test case
  selftests/nolibc: add mmap_munmap_good test case

 tools/include/nolibc/arch-aarch64.h          |  28 ++--
 tools/include/nolibc/arch-arm.h              |  28 ++--
 tools/include/nolibc/arch-i386.h             |  24 ++--
 tools/include/nolibc/arch-loongarch.h        |  37 +++---
 tools/include/nolibc/arch-mips.h             |  73 +++++++----
 tools/include/nolibc/arch-riscv.h            |  14 +-
 tools/include/nolibc/arch-s390.h             |  14 +-
 tools/include/nolibc/arch-x86_64.h           |  28 ++--
 tools/include/nolibc/nolibc.h                |   9 +-
 tools/include/nolibc/sys.h                   |  55 ++++----
 tools/include/nolibc/types.h                 |   6 +
 tools/testing/selftests/nolibc/nolibc-test.c | 129 ++++++++++++++++++-
 12 files changed, 292 insertions(+), 153 deletions(-)

--
2.25.1




More information about the linux-riscv mailing list