[PATCH v3 03/11] PCI: microchip: enable building this driver as a module
Conor Dooley
conor at kernel.org
Wed Jan 11 10:20:05 PST 2023
On Wed, Jan 11, 2023 at 12:53:15PM +0000, daire.mcnamara at microchip.com wrote:
> From: Daire McNamara <daire.mcnamara at microchip.com>
>
> Enable building this driver as a module. The expected use case is the
> driver is built as a module, is installed when needed, and cannot be
> removed once installed.
>
> The remove() callback is not implemented as removing a driver with
> INTx and MSI interrupt handling is inherently unsafe.
>
> Link: https://lore.kernel.org/linux-pci/87y1wgbah8.wl-maz@kernel.org/
> Suggested-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> Signed-off-by: Daire McNamara <daire.mcnamara at microchip.com>
Perhaps, if nothing else crops up, Uwe's comment about the commit
message can be addressed on application?
Either way,
Acked-by: Conor Dooley <conor.dooley at microchip.com>
Thanks!
> ---
> drivers/pci/controller/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig
> index 76806dc52d1b..fd005b3f8a24 100644
> --- a/drivers/pci/controller/Kconfig
> +++ b/drivers/pci/controller/Kconfig
> @@ -291,7 +291,7 @@ config PCI_LOONGSON
> Loongson systems.
>
> config PCIE_MICROCHIP_HOST
> - bool "Microchip AXI PCIe host bridge support"
> + tristate "Microchip AXI PCIe host bridge support"
> depends on PCI_MSI
> select PCI_MSI_IRQ_DOMAIN
> select GENERIC_MSI_IRQ_DOMAIN
> --
> 2.25.1
>
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-riscv/attachments/20230111/cc442fae/attachment.sig>
More information about the linux-riscv
mailing list