[PATCH v1 0/3] Remove toolchain dependencies for Zicbom

Conor Dooley conor at kernel.org
Sun Jan 8 08:33:53 PST 2023


From: Conor Dooley <conor.dooley at microchip.com>

Hey all,

I've yoinked patch 1 from Drew's series adding support for Zicboz &
attached two more patches here that remove the need for, and then drop
the toolchain support checks for Zicbom. The goal is to remove the need
for checking the presence of toolchain Zicbom support in the work being
done to support non instruction based CMOs [1].

I've tested compliation on a number of different configurations with
the Zicbom config option enabled. The important ones to call out I
guess are:
- clang/llvm 14 w/ LLVM=1 which doesn't support Zicbom atm.
- gcc 11 w/ binutils 2.37 which doesn't support Zicbom atm either.
- clang/llvm 15 w/ LLVM=1 BUT with binutils 2.37's ld. This is the
  configuration that prompted adding the LD checks as cc/as supports
  Zicbom, but ld doesn't [2].
- gcc 12 w/ binutils 2.39 & clang 15 w/ LLVM=1, both of these supported
  Zicbom before and still do.

I also checked building the THEAD errata etc with
CONFIG_RISCV_ISA_ZICBOM disabled, and there were no build issues there
either.

Drew - I took the liberty of dropping the cbo.zero addition from your
patch.

Thanks,
Conor.

1 - https://lore.kernel.org/linux-riscv/fb3b34ae-e35e-4dc2-a8f4-19984a2f58a8@app.fastmail.com/
2 - https://lore.kernel.org/linux-riscv/20221006173520.1785507-1-conor@kernel.org/

CC: Arnd Bergmann <arnd at arndb.de>
CC: Conor Dooley <conor.dooley at microchip.com>
CC: Geert Uytterhoeven <geert+renesas at glider.be>
CC: Heiko Stuebner <heiko at sntech.de>
CC: Guo Ren <guoren at kernel.org>
CC: Andrew Jones <ajones at ventanamicro.com>
CC: Palmer Dabbelt <palmer at dabbelt.com>
CC: Lad Prabhakar <prabhakar.mahadev-lad.rj at bp.renesas.com>
CC: linux-riscv at lists.infradead.org
CC: linux-riscv at lists.infradead.org

Andrew Jones (1):
  RISC-V: insn-def: Add I-type insn-def

Conor Dooley (2):
  RISC-V: replace cbom instructions with an insn-def
  RISC-V: remove toolchain version checks for Zicbom

 arch/riscv/Kconfig                   |  8 ----
 arch/riscv/Makefile                  |  3 --
 arch/riscv/include/asm/errata_list.h |  3 +-
 arch/riscv/include/asm/insn-def.h    | 58 ++++++++++++++++++++++++++++
 4 files changed, 60 insertions(+), 12 deletions(-)

-- 
2.39.0




More information about the linux-riscv mailing list