[PATCH v1 5/7] soc: starfive: Use call back to parse device tree resources
Conor Dooley
conor.dooley at microchip.com
Tue Apr 11 23:27:03 PDT 2023
On Wed, Apr 12, 2023 at 02:07:52PM +0800, Walker Chen wrote:
>
>
> On 2023/4/11 14:47, Changhuang Liang wrote:
> > Different compatible parse device tree resources work in different ways.
> >
> > Signed-off-by: Changhuang Liang <changhuang.liang at starfivetech.com>
>
> I don't think it's necessary to submit multiple patches separately for the same .c file
> unless it is very necessary. Because the disadvantage of separating multiple patches
> is that some information lacks completeness and coherence.
Other than patches 4 & 6, which could be squashed, the breakdown here is
fine IMO. Doing one thing per patch makes it obvious to the reader
*what* is happening.
There's just some missing boilerplate in the commit messages across the
series that the DPHY PMU does not have a reg nor interrupts, and this
work is being done to support that.
Cheers,
Conor.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-riscv/attachments/20230412/cdb5ee2d/attachment.sig>
More information about the linux-riscv
mailing list