[PATCH v4 12/12] RISC-V: fix auipc-jalr addresses in patched alternatives

Conor Dooley conor at kernel.org
Wed Dec 7 14:04:19 PST 2022


On Wed, Dec 07, 2022 at 10:00:13PM +0000, Jessica Clarke wrote:

> >> +static u32 riscv_instruction_at(void *p)
> >> +{
> >> +	u16 *parcel = p;
> >> +
> >> +	return (unsigned int)parcel[0] | (unsigned int)parcel[1] << 16;
> > 
> > I feel bad for not mentioning this before - can we replace this magic 16
> > with something self documenting?
> 
> I mean, it’s a u16 * two lines above, that seems a bit unnecessary...

I guess that's why I didn't mention it before... Can safely disregard
that request so Heiko!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-riscv/attachments/20221207/3bedc560/attachment.sig>


More information about the linux-riscv mailing list